pg.ddx.io pgsql-performance@postgresql.org mailing list archive
help / color / mirror / Atom feed From: Dave Cramer <pg@fastcrypt.com>
To: Paul Tuckfield <paul@tuckfield.com>
Cc: Anjan Dave <adave@vantage.com>
Cc: Josh Berkus <josh@agliodbs.com>
Cc: Neil Conway <neilc@samurai.com>
Cc: Dirk Lutzebäck <lutzeb@aeccom.com>
Cc: pgsql-performance@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Wierd context-switching issue on Xeon patch for 7.4.1
Date: Wed, 21 Apr 2004 16:49:48 -0400
Message-ID: <1082580588.13371.260.camel@localhost.localdomain> (raw )
In-Reply-To: <1082574808.1558.243.camel@localhost.localdomain >
References: <4BAFBB6B9CC46F41B2AD7D9F4BBAF78509814A@vt-pe2550-001.vantage.vantage.com >
<200404200959.52813.josh@agliodbs.com >
<1082515263.1558.214.camel@localhost.localdomain >
<78427208-93C0-11D8-BA67-000393BD6C3E@tuckfield.com >
<1082574808.1558.243.camel@localhost.localdomain >
attached.
--
Dave Cramer
519 939 0336
ICQ # 14675561
Attachments:
spinlock.patch (text/x-patch, 1.9K) download
Index: backend/storage/lmgr/s_lock.c
===================================================================
RCS file: /usr/local/cvs/pgsql-server/src/backend/storage/lmgr/s_lock.c,v
retrieving revision 1.16
diff -c -r1.16 s_lock.c
*** backend/storage/lmgr/s_lock.c 8 Aug 2003 21:42:00 -0000 1.16
--- backend/storage/lmgr/s_lock.c 21 Apr 2004 20:27:34 -0000
***************
*** 76,82 ****
* The select() delays are measured in centiseconds (0.01 sec) because 10
* msec is a common resolution limit at the OS level.
*/
! #define SPINS_PER_DELAY 100
#define NUM_DELAYS 1000
#define MIN_DELAY_CSEC 1
#define MAX_DELAY_CSEC 100
--- 76,82 ----
* The select() delays are measured in centiseconds (0.01 sec) because 10
* msec is a common resolution limit at the OS level.
*/
! #define SPINS_PER_DELAY 10
#define NUM_DELAYS 1000
#define MIN_DELAY_CSEC 1
#define MAX_DELAY_CSEC 100
***************
*** 88,93 ****
--- 88,94 ----
while (TAS(lock))
{
+ __asm__ __volatile__ ( "rep;nop": : :"memory");
if (++spins > SPINS_PER_DELAY)
{
if (++delays > NUM_DELAYS)
Index: include/storage/s_lock.h
===================================================================
RCS file: /usr/local/cvs/pgsql-server/src/include/storage/s_lock.h,v
retrieving revision 1.115.2.1
diff -c -r1.115.2.1 s_lock.h
*** include/storage/s_lock.h 4 Nov 2003 09:43:56 -0000 1.115.2.1
--- include/storage/s_lock.h 21 Apr 2004 20:26:25 -0000
***************
*** 103,110 ****
register slock_t _res = 1;
__asm__ __volatile__(
! " lock \n"
" xchgb %0,%1 \n"
: "=q"(_res), "=m"(*lock)
: "0"(_res));
return (int) _res;
--- 103,113 ----
register slock_t _res = 1;
__asm__ __volatile__(
! " cmpb $0,%1 \n"
! " jne 1f \n"
! " lock \n"
" xchgb %0,%1 \n"
+ " 1:\n"
: "=q"(_res), "=m"(*lock)
: "0"(_res));
return (int) _res;
view thread (22+ messages) latest in thread
Message-ID: <1082580588.13371.260.camel@localhost.localdomain>
Permalink: ../1082580588.13371.260.camel@localhost.localdomain/
Also on: postgresql.org/message-id/1082580588.13371.260.camel@localhost.localdomain
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: pg@fastcrypt.com, paul@tuckfield.com, adave@vantage.com, josh@agliodbs.com, neilc@samurai.com, lutzeb@aeccom.com, tgl@sss.pgh.pa.us
Subject: Re: Wierd context-switching issue on Xeon patch for 7.4.1
In-Reply-To: <1082580588.13371.260.camel@localhost.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox