From: Neil Conway <neilc@samurai.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Marinos Yannikos <mjy@geizhals.at>
Cc: Oleg Bartunov <oleg@sai.msu.su>
Cc: pgsql-performance@postgresql.org
Subject: Re: GiST indexes and concurrency (tsearch2)
Date: Thu, 10 Feb 2005 12:13:03 +1100
Message-ID: <1107997983.1286.132.camel@localhost.localdomain> (raw)
In-Reply-To: <28977.1107632554@sss.pgh.pa.us>
References: <4201AEB1.4000504@geizhals.at>
<Pine.GSO.4.62.0502031255350.20328@ra.sai.msu.su>
<4202053B.10207@geizhals.at>
<Pine.GSO.4.62.0502031514090.20328@ra.sai.msu.su>
<4204C3B4.1050209@geizhals.at>
<28977.1107632554@sss.pgh.pa.us>
On Sat, 2005-02-05 at 14:42 -0500, Tom Lane wrote:
> Marinos Yannikos <mjy@geizhals.at> writes:
> > Some more things I tried:
>
> You might try the attached patch (which I just applied to HEAD).
> It cuts down the number of acquisitions of the BufMgrLock by merging
> adjacent bufmgr calls during a GIST index search.
I'm not sure it will help much either, but there is more low-hanging
fruit in this area: GiST currently does a ReadBuffer() for each tuple
produced by the index scan, which is grossly inefficient. I recently
applied a patch to change rtree to keep a pin on the scan's current
buffer in between invocations of the index scan API (which is how btree
and hash already work), and it improved performance by about 10%
(according to contrib/rtree_gist's benchmark). I've made similar changes
for GiST, but unfortunately it is part of a larger GiST improvement
patch that I haven't had a chance to commit to 8.1 yet:
http://archives.postgresql.org/pgsql-patches/2004-11/msg00144.php
I'll try and get this cleaned up for application to HEAD next week.
-Neil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: neilc@samurai.com, tgl@sss.pgh.pa.us, mjy@geizhals.at, oleg@sai.msu.su
Subject: Re: GiST indexes and concurrency (tsearch2)
In-Reply-To: <1107997983.1286.132.camel@localhost.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox