From: Simon Riggs <simon@2ndquadrant.com>
To: Martijn van Oosterhout <kleptog@svana.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ron Peacetree <rjpeace@earthlink.net>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] A Better External Sort?
Date: Mon, 03 Oct 2005 22:51:32 +0100
Message-ID: <1128376292.8603.142.camel@localhost.localdomain> (raw)
In-Reply-To: <20051002193835.GJ30492@svana.org>
References: <18329659.1128188552696.JavaMail.root@elwamui-polski.atl.sa.earthlink.net>
<20051001215602.GG13830@svana.org>
<29837.1128223567@sss.pgh.pa.us>
<20051002123240.GA30492@svana.org>
<20051002193835.GJ30492@svana.org>
On Sun, 2005-10-02 at 21:38 +0200, Martijn van Oosterhout wrote:
> Ok, I tried two optimisations:
>
> 2. By specifying: -Winline -finline-limit-1500 (only on tuplesort.c).
> This causes inlineApplySortFunction() to be inlined, like the code
> obviously expects it to be.
>
> default build (baseline) 235 seconds
> -finline only 217 seconds (7% better)
> comparetup_index_fastbyval4 only 221 seconds (6% better)
> comparetup_index_fastbyval4 and -finline 203 seconds (13.5% better)
>
> This is indexing the integer sequence column on a 2.7 million row
> table. The times are as given by gprof and so exclude system call time.
>
> Basically, I recommend adding "-Winline -finline-limit-1500" to the
> default build while we discuss other options.
I add -Winline but get no warnings. Why would I use -finline-limit-1500?
I'm interested, but uncertain as to what difference this makes. Surely
using -O3 works fine?
Best Regards, Simon Riggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: simon@2ndquadrant.com, kleptog@svana.org, tgl@sss.pgh.pa.us, rjpeace@earthlink.net, pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] A Better External Sort?
In-Reply-To: <1128376292.8603.142.camel@localhost.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox