From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: Bertrand Petit <elrond@phoe.frmug.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: 7.4 beta 1 getting out of swap
Date: Fri, 15 Aug 2003 07:09:58 -0400
Message-ID: <12303.1060945798@sss.pgh.pa.us> (raw)
In-Reply-To: <3F3C497C.1050200@joeconway.com>
References: <20030814122130.A3583@memo.frmug.org>
<15589.1060861546@sss.pgh.pa.us>
<20030814165311.A4431@memo.frmug.org>
<1578.1060874322@sss.pgh.pa.us>
<20030814200947.A4769@memo.frmug.org>
<7037.1060889820@sss.pgh.pa.us>
<20030814215410.A5336@memo.frmug.org>
<7271.1060891412@sss.pgh.pa.us>
<20030815001730.A5628@memo.frmug.org>
<8826.1060906670@sss.pgh.pa.us>
<3F3C497C.1050200@joeconway.com>
Joe Conway <mail@joeconway.com> writes:
> Tom Lane wrote:
>> 3. Set up a long-lived cache internal to the array functions that can
>> translate element type OID to the needed lookup data, and won't leak
>> memory across repeated calls. This is not the fastest or most general
>> solution, but it seems the most localized and safest fix.
> It seems to me that #3 is the least risky, and even if it isn't the best
> possible performance, this is the initial implementation of indexes on
> arrays, so it isn't like we're taking away something. Maybe solution #2
> is better held as a performance enhancement for 7.5.
I'm leaning that way too. It occurs to me also that the same cache
could be used to eliminate repeated lookups in sorting setup --- which
would not be much of a win percentagewise, compared to the sort itself,
but still it seems worth doing.
> Do you want me to take a shot at this since I created the mess?
Actually I led you down the garden path on that, IIRC --- I was the one
who insisted these lookups needed to be cached. I'll work on fixing it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-performance@postgresql.org
Cc: tgl@sss.pgh.pa.us, mail@joeconway.com, elrond@phoe.frmug.org, pgsql-hackers@postgresql.org
Subject: Re: 7.4 beta 1 getting out of swap
In-Reply-To: <12303.1060945798@sss.pgh.pa.us>
References: <20030814122130.A3583@memo.frmug.org> <15589.1060861546@sss.pgh.pa.us> <20030814165311.A4431@memo.frmug.org> <1578.1060874322@sss.pgh.pa.us> <20030814200947.A4769@memo.frmug.org> <7037.1060889820@sss.pgh.pa.us> <20030814215410.A5336@memo.frmug.org> <7271.1060891412@sss.pgh.pa.us> <20030815001730.A5628@memo.frmug.org> <8826.1060906670@sss.pgh.pa.us> <3F3C497C.1050200@joeconway.com> <12303.1060945798@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox