pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: simon@2ndquadrant.com
Cc: 'Neil Conway' <neilc@samurai.com>
Cc: josh@agliodbs.com, "'Rob Fielding'" <rob@dsvr.net>
Cc: pgsql-performance@postgresql.org
Cc: pgsql-hackers-pitr@postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] [PERFORM] WAL Optimisation - configuration and usage
Date: Wed, 03 Mar 2004 18:46:23 -0500
Message-ID: <19294.1078357583@sss.pgh.pa.us> (raw)
In-Reply-To: <006801c40168$1db208d0$5baa87d9@LaptopDellXP>
References: <006801c40168$1db208d0$5baa87d9@LaptopDellXP>

"Simon Riggs" <simon@2ndquadrant.com> writes:
> The behaviour I wish to add is:
> Keep wal_debug as a value between 0 and 16.
> If =0 then no debug output (default).
> Use following bitmasks against the value
> Mask 1 = XLOG Checkpoints get logged
> Mask 2 = Archive API calls get logged
> Mask 4 = Transaction - commits get logged
> Mask 8 = Flush & INSERTs get logged

I see no value in reverting Neil's change.  The above looks way too much
like old-line assembler-programmer thinking to me, anyway.  Why not
invent a separate, appropriately named boolean variable for each thing
you want to control?  Even C programmers manage to avoid doing the sort
of mental arithmetic that the above would force onto DBAs.

As for whether it should be #ifdef'd or not, I'd have no objection to
turning WAL_DEBUG on by default in pg_config_manual.h for the duration
of PITR development.  One should not however confuse short-term
debugging needs with features that the average user is going to need
indefinitely.  (It was not too long ago that there was still debugging
code for btree index building in there, for crissakes.)

			regards, tom lane



view thread (18+ messages)  latest in thread

Message-ID: <19294.1078357583@sss.pgh.pa.us>
Permalink:  ../19294.1078357583@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19294.1078357583@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: tgl@sss.pgh.pa.us, simon@2ndquadrant.com, neilc@samurai.com, rob@dsvr.net, pgsql-hackers-pitr@postgresql.org, pgsql-hackers@postgresql.org
  Subject: Re: [HACKERS] [PERFORM] WAL Optimisation - configuration and usage
  In-Reply-To: <19294.1078357583@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox