From: Tom Lane <tgl@sss.pgh.pa.us>
To: Greg Stark <gsstark@mit.edu>
Cc: Jim C. Nasby <jim@nasby.net>
Cc: pgsql-performance@postgresql.org
Subject: Re: Horribly slow hash join
Date: Sun, 18 Apr 2004 11:46:35 -0400
Message-ID: <19739.1082303195@sss.pgh.pa.us> (raw)
In-Reply-To: <873c719476.fsf@stark.xeocode.com>
References: <20040416154502.GF87362@nasby.net>
<450.1082133251@sss.pgh.pa.us>
<20040416164644.GH87362@nasby.net>
<808.1082135098@sss.pgh.pa.us>
<20040416172523.GJ87362@nasby.net>
<1263.1082138383@sss.pgh.pa.us>
<20040416184541.GK87362@nasby.net>
<10603.1082218095@sss.pgh.pa.us>
<878ygu8auw.fsf@stark.xeocode.com>
<15053.1082259958@sss.pgh.pa.us>
<873c719476.fsf@stark.xeocode.com>
Greg Stark <gsstark@mit.edu> writes:
> Eh? Oh, negative numbers? So low^high^sign.
[ thinks about it... ] Yeah, that would work. We can't backpatch it
without breaking existing hash indexes on int8, but it'd be reasonable
to change for 7.5 (since at the rate things are going, we won't have
pg_upgrade for 7.5 anyway...)
> I wonder if it makes sense to have check the hash distribution after
> generating the table and if it's bad then throw it away and try again with a
> different hash function. The "different hash function" would probably just be
> a seed value changing. Probably way overkill though.
Yeah, it'd be a pain trying to get all the type-specific hash functions
doing that. I'm also unconvinced that a simple change of seed value
would necessarily make the distribution better. In the worst case, if
the real problem is that all the input values are identical, you can
reseed all day long and it won't fix it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: tgl@sss.pgh.pa.us, gsstark@mit.edu, jim@nasby.net
Subject: Re: Horribly slow hash join
In-Reply-To: <19739.1082303195@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox