From: Robert Treat <xzilla@users.sourceforge.net>
To: pgsql-performance@postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@commandprompt.com>
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Date: Sat, 26 Apr 2008 09:10:53 -0400
Message-ID: <200804260910.55203.xzilla@users.sourceforge.net> (raw)
In-Reply-To: <865.1209159179@sss.pgh.pa.us>
References: <20080317021856.0D2D37558DC@cvs.postgresql.org>
<200804251724.48705.xzilla@users.sourceforge.net>
<865.1209159179@sss.pgh.pa.us>
On Friday 25 April 2008 17:32, Tom Lane wrote:
> Robert Treat <xzilla@users.sourceforge.net> writes:
> > Oddly some dtrace profiling gave me this, which is pretty different, but
> > certainly doesn't have concerns about TransactionIdIsCurrentTransactionId
>
> .... which seems to pretty much destroy your thesis, no?
>
How so? Before the patch we bog down for hours, spending 99% of our time in
TransactionIdIsCurrentTransactionId, after the patch everything performs well
(really better than before) and we spend so little time in
TransactionIdIsCurrentTransactionId it barely shows up on the radar.
Note I'm open to the idea that TransactionIdIsCurrentTransactionId itself is
not the problem, but that something else changed between 8.1 and 8.3 that
exposes TransactionIdIsCurrentTransactionId as a problem. Changing to a
binary search for TransactionIdIsCurrentTransactionId makes that a non-issue
though.
--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: xzilla@users.sourceforge.net, tgl@sss.pgh.pa.us, alvherre@commandprompt.com
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
In-Reply-To: <200804260910.55203.xzilla@users.sourceforge.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox