pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephan Szabo <sszabo@megazone23.bigpanda.com>
Cc: Kevin Brown <kevin@sysexperts.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] Foreign key performance
Date: Sat, 19 Apr 2003 16:58:02 -0400
Message-ID: <23461.1050785882@sss.pgh.pa.us> (raw)
In-Reply-To: <20030419114146.E18449-200000@megazone23.bigpanda.com>
References: <20030419114146.E18449-200000@megazone23.bigpanda.com>

Stephan Szabo <sszabo@megazone23.bigpanda.com> writes:
> The hack was just the keeping around the list pointer from the last run
> through (see attached - passed simple fk tests and regression, but there
> might be problems I don't see).

Shouldn't this patch update the comment in deferredTriggerInvokeEvents
(c. line 1860 in cvs tip)?

> Looking at the code, I also wonder if we
> would get some gain by not allocating the per_tuple_context at the
> beginning but only when a non-deferred constraint is found since otherwise
> we're creating and destroying the context and possibly never using it.

I doubt it's worth worrying over.  Creation/destruction of a never-used
memory context is pretty cheap, I think.

			regards, tom lane




view thread (18+ messages)  latest in thread

Message-ID: <23461.1050785882@sss.pgh.pa.us>
Permalink:  ../23461.1050785882@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/23461.1050785882@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: tgl@sss.pgh.pa.us, sszabo@megazone23.bigpanda.com, kevin@sysexperts.com, pgsql-hackers@postgresql.org
  Subject: Re: [PERFORM] Foreign key performance
  In-Reply-To: <23461.1050785882@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox