pg.ddx.io pgsql-performance@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Jakub Glapa <jakub.glapa@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Fabio Isabettini <fisabettini@voipfuture.com>
Cc: Arne Roland <A.Roland@index.de>
Cc: Sand Stone <sand.m.stone@gmail.com>
Cc: Rick Otten <rottenwindfish@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: dsa_allocate() faliure
Date: Sun, 10 Feb 2019 20:22:45 -0500
Message-ID: <25697.1549848165@sss.pgh.pa.us> (raw )
In-Reply-To: <CAEepm=269dTFxHEapRhm8vf_GEkjSY_p2oU5Ngp48GZQKwyMnA@mail.gmail.com >
References: <CAMAYy4+w3NTBM5JLWFi8twhWK4=k_5L4nV5+bYDSPu8r4b97Zg@mail.gmail.com >
<6f3fe9fa5a984dc19e40e79fbef45edc@index.de >
<6c2e8a16999f4e17b975d7369f6605b4@index.de >
<CAEepm=0p5nJDAjZoqa9ovdJC_sDwbhWcwBCkVS_iSEtXR9ZYYg@mail.gmail.com >
<45C7466A-7D67-4BB4-829C-F66CBB2961DB@voipfuture.com >
<CAEepm=1RA7OZPWZ0BOY4JUm5MxxXt4cN3Jq3Y82MmfgvBj4ghw@mail.gmail.com >
<CAJk1zg28tqx2021D0j-RqFtbLe+SPj4JKdmnc+K2aJZTUYk3eQ@mail.gmail.com >
<20190206232110.GH29720@telsasoft.com >
<CAJk1zg1aD9QieKBR0BzewDWFxbio+XakDFE7NcYzOk0JSm0tMg@mail.gmail.com >
<CAEepm=1MvOE-Sfv1chudx5KEmw_qHYrj8F9Og_WmdBRhXSQ++w@mail.gmail.com >
<CAEepm=2LOk6WgOcS31n0xJ9akgKP7E0gbYmbqz27D8vP6s1Rrw@mail.gmail.com >
<CA+TgmoY=VEAMFoeRtP4j-ZOKM-B=4j671j5GKb3gYQ94-PgjhA@mail.gmail.com >
<CAEepm=0m9PMTe3_+evvgOQPPxP1=hYNNoSdbE1o2FnqCqrFBwQ@mail.gmail.com >
<CAEepm=2X8jDzJNj5UbnmdWcFfzRo6ZMpX2TAmApwzPc9thvo0w@mail.gmail.com >
<CA+TgmoY4t7r9ac2vRnX1grL7yAaN9hJK6kG_8-D6ro8hNNjz-w@mail.gmail.com >
<CAEepm=1C3t0B9yXDFtNgPDS0c--RZjDQuaC! pFCaCaFUbPb6AFQ@mail.gmail.com >
<15839.1549841633@sss.pgh.pa.us >
<CAEepm=269dTFxHEapRhm8vf_GEkjSY_p2oU5Ngp48GZQKwyMnA@mail.gmail.com >
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Mon, Feb 11, 2019 at 10:33 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I observe from
>> https://coverage.postgresql.org/src/backend/utils/mmgr/freepage.c.gcov.html
>> that the edge cases in this function aren't too well exercised by
>> our regression tests, meaning that the buildfarm might not prove
>> much either way about the correctness of this patch. That is one
>> factor pushing me to think we shouldn't risk it. But, taking a
>> longer view, is that something that's practical to improve?
> Yeah. This is a nice example of code that really deserves unit tests
> written in C. Could be good motivation to built the infrastructure I
> mentioned here:
> https://www.postgresql.org/message-id/flat/CAEepm%3D2heu%2B5zwB65jWap3XY-UP6PpJZiKLQRSV2UQH9BmVRXQ%4...
Meh. I think if you hold out for that, you're going to be waiting a
long time. I was thinking more along the lines of making a test API
in src/test/modules/, akin to what we've got for predtest or rbtree.
regards, tom lane
view thread (60+ messages) latest in thread
Message-ID: <25697.1549848165@sss.pgh.pa.us>
Permalink: ../25697.1549848165@sss.pgh.pa.us/
Also on: postgresql.org/message-id/25697.1549848165@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, robertmhaas@gmail.com, jakub.glapa@gmail.com, pryzby@telsasoft.com, fisabettini@voipfuture.com, A.Roland@index.de, sand.m.stone@gmail.com, rottenwindfish@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: dsa_allocate() faliure
In-Reply-To: <25697.1549848165@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox