pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki@enterprisedb.com>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Craig Ringer <craig@postnewspapers.com.au>
Cc: pgsql-patches <pgsql-patches@postgresql.org>
Subject: Re: [PERFORM] Very slow (2 tuples/second) sequentialscan after bulk insert; speed returns to ~500 tuples/second aftercommit
Date: Tue, 11 Mar 2008 14:03:08 +0000
Message-ID: <47D6911C.3040605@enterprisedb.com> (raw)
In-Reply-To: <20080311132904.GA9116@alvh.no-ip.org>
References: <47D505AF.4040101@postnewspapers.com.au>
	<47D5150C.8090802@enterprisedb.com>
	<23588.1205159638@sss.pgh.pa.us>
	<47D54A47.3030608@postnewspapers.com.au>
	<47D54DB2.4020405@enterprisedb.com>
	<24304.1205162440@sss.pgh.pa.us>
	<47D67C3F.1030406@enterprisedb.com>
	<20080311132904.GA9116@alvh.no-ip.org>

Alvaro Herrera wrote:
> Heikki Linnakangas wrote:
> 
>> I couldn't let this case go, so I wrote a patch. I replaced the linked  
>> list with an array that's enlarged at AtSubCommit_childXids when 
>> necessary.
> 
> Do you still need to palloc the return value from
> xactGetCommittedChildren?  Perhaps you can save the palloc/memcpy/pfree
> and just return the pointer to the array already in memory?

Yeah, good point. The callers just need to be modified not to pfree it.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com



Message-ID: <47D6911C.3040605@enterprisedb.com>
Permalink:  ../47D6911C.3040605@enterprisedb.com/
Also on:    postgresql.org/message-id/47D6911C.3040605@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: heikki@enterprisedb.com, alvherre@commandprompt.com, tgl@sss.pgh.pa.us, craig@postnewspapers.com.au, pgsql-patches@postgresql.org
  Subject: Re: [PERFORM] Very slow (2 tuples/second) sequentialscan after bulk insert; speed returns to ~500 tuples/second aftercommit
  In-Reply-To: <47D6911C.3040605@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox