pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jim Nasby <jnasby@pervasive.com>
To: Witold Strzelczyk <w.strzelczyk@digitalone.pl>
Cc: Pgsql-Performance \(E-mail\) <pgsql-performance@postgresql.org>
Subject: Re: slow variable against int??
Date: Fri, 12 May 2006 11:09:27 -0500
Message-ID: <4D27CB1096EF1C408F4BFAB0046EC7B6099F55@ausmailid.aus.pervasive.com> (raw)

Please cc the list so others can help.

> From: Witold Strzelczyk [mailto:w.strzelczyk@digitalone.pl]
> On Friday 12 May 2006 00:04, you wrote:
> 
> Yes, thanks but method is not a  point.

Actually, it is a point. Databases don't like doing things procedurally. Using a stored procedure to operate on a set of data is very often the wrong way to go about it. In the case of ranking, I'm extremely doubtful that you'll ever get a procedure to opperate anywhere near as fast as native SQL.

> Can You tell me why 
> 
> 		select into inGameRating  count(game_result)+1 
> from users
>  		where game_result > 2984;
> 
> tooks ~100 ms and
> 
>  		select into inGameRating  count(game_result)+1 
> from users
>  		where game_result > inRow.game_result;
> 
> where inRow.game_result = 2984 tooks ~1100 ms!?

No, I can't. What's EXPLAIN ANALYZE show?

> btw. I must try your temp sequence but if it is not as quick 
> as my new (and 
> final) function I'll send if to you.
> 
> > If you're trying to come up with ranking then you'll be much happier
> > using a sequence and pulling from it using an ordered 
> select. See lines
> > 19-27 in http://lnk.nu/cvs.distributed.net/9bu.sql for an example.
> > Depending on what you're doing you might not need the temp table.
> >
> > On Fri, May 05, 2006 at 04:46:43PM +0200, Witold Strzelczyk wrote:
> > > I have a question about my function. I must get user 
> rating by game
> > > result. This isn't probably a perfect solution but I have 
> one question
> > > about
> > >
> > > select into inGameRating  count(game_result)+1 from users
> > > 		where game_result > inRow.game_result;
> > >
> > > This query in function results in about 1100 ms.
> > > inRow.game_result is a integer 2984
> > > And now if I replace inRow.game_result with integer
> > >
> > > select into inGameRating  count(game_result)+1 from users
> > > 		where game_result > 2984;
> > >
> > > query results in about 100 ms
> > >
> > > There is probably a reason for this but can you tell me 
> about it because
> > > I can't fine one
> > >
> > > My function:
> > >
> > > create or replace function ttt_result(int,int) returns setof
> > > tparent_result language plpgsql volatile as $$
> > > declare
> > > 	inOffset alias for $1;
> > > 	inLimit alias for $2;
> > > 	inRow tparent_result%rowtype;
> > > 	inGameResult int := -1;
> > > 	inGameRating int := -1;
> > > begin
> > >
> > > for inRow in
> > > 	select
> > > 		email,wynik_gra
> > > 	from
> > > 		konkurs_uzytkownik
> > > 	order by wynik_gra desc limit inLimit offset inOffset
> > > loop
> > > 	if inGameResult  < 0 then -- only for first iteration
> > > 		/* this is fast ~100 ms
> > > 		select into inGameRating
> > > 			count(game_result)+1 from users
> > > 			where game_result > 	2984;
> > > 		*/
> > > 		/* even if inRow.game_result = 2984 this is 
> very slow ~ 1100 ms!
> > > 		select into inGameRating  count(game_result)+1 
> from users
> > > 		where game_result > inRow.game_result;
> > > 		*/
> > > 		inGameResult  := inRow.game_result;
> > > 	end if;
> > >
> > > 	if inGameResult  > inRow.game_result then
> > > 		inGameRating  := inGameRating  + 1;
> > > 	end if;
> > >
> > > 	inRow.game_rating := inGameRating;
> > > 	inGameResult       := inRow.game_result;
> > > 	return next inRow;
> > >
> > > end loop;
> > > return;
> > > end;
> > > $$;
> > > --
> > > Witold Strzelczyk
> > > witek.strzelczyk@gmail.com
> > >
> > > ---------------------------(end of 
> broadcast)---------------------------
> > > TIP 9: In versions below 8.0, the planner will ignore 
> your desire to
> > >        choose an index scan if your joining column's 
> datatypes do not
> > >        match
> 
> -- 
> Witold Strzelczyk
> 
>   : :   D i g i t a l  O n e  : :  http://www.digitalone.pl
>   : :   Dowborczykow 25  Lodz  90-019  Poland
>   : :   tel. [+48 42] 6771477  fax [+48 42] 6771478
> 
>    ...Where Internet works for effective business solutions...
> 



view thread (3+ messages)

Message-ID: <4D27CB1096EF1C408F4BFAB0046EC7B6099F55@ausmailid.aus.pervasive.com>
Permalink:  ../4D27CB1096EF1C408F4BFAB0046EC7B6099F55@ausmailid.aus.pervasive.com/
Also on:    postgresql.org/message-id/4D27CB1096EF1C408F4BFAB0046EC7B6099F55@ausmailid.aus.pervasive.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: jnasby@pervasive.com, w.strzelczyk@digitalone.pl
  Subject: Re: slow variable against int??
  In-Reply-To: <4D27CB1096EF1C408F4BFAB0046EC7B6099F55@ausmailid.aus.pervasive.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox