From: Greg Smith <greg@2ndquadrant.com>
To: Euler Taveira de Oliveira <euler@timbira.com>
Cc: pgsql-performance@postgresql.org <pgsql-performance@postgresql.org>
Subject: Re: pgbench to the MAXINT
Date: Mon, 10 Jan 2011 03:25:23 -0500
Message-ID: <4D2AC273.3010709@2ndquadrant.com> (raw)
In-Reply-To: <4D2A965A.3000603@timbira.com>
References: <4D27C4E5.5000609@2ndquadrant.com>
<4D2A965A.3000603@timbira.com>
Euler Taveira de Oliveira wrote:
> Em 07-01-2011 22:59, Greg Smith escreveu:
>> setrandom: invalid maximum number -2147467296
>>
> It is failing at atoi() circa pgbench.c:1036. But it just the first
> one. There are some variables and constants that need to be converted
> to int64 and some functions that must speak 64-bit such as getrand().
> Are you working on a patch?
http://archives.postgresql.org/pgsql-hackers/2010-01/msg02868.phphttp://archives.postgresql.org/message-id/4C326F46.4050801@2ndquadrant.com
I thought we really needed to fix that before 9.0 shipped, but it turned
out the limit wasn't so bad after all on 64-bit systems; I dropped
worrying about it for a while. It's starting to look like it's back on
the critical list for 9.1 again though.
If anyone here wanted to pick that up and help with review, I could
easily update to it to current git HEAD and re-post. There's enough
people on this list who do tests on large machines that I was mainly
alerting to where the breaking point is at, the fix required has already
been worked on a bit. Someone with more patience than I to play around
with multi-platform string conversion trivia is what I think is really
needed next, followed by some performance tests on 32-bit systems.
--
Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.us
"PostgreSQL 9.0 High Performance": http://www.2ndQuadrant.com/books
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: greg@2ndquadrant.com, euler@timbira.com
Subject: Re: pgbench to the MAXINT
In-Reply-To: <4D2AC273.3010709@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox