pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: ldh@laurent-hasson.com <ldh@laurent-hasson.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-performance@postgresql.org <pgsql-performance@postgresql.org>
Subject: Re: Big performance slowdown from 11.2 to 13.3
Date: Thu, 22 Jul 2021 12:26:50 -0400
Message-ID: <786910.1626971210@sss.pgh.pa.us> (raw)
In-Reply-To: <786600.1626970898@sss.pgh.pa.us>
References: <MN2PR15MB25601E80A9B6D1BA6F592B1985E39@MN2PR15MB2560.namprd15.prod.outlook.com>
	<20210721191528.GC19620@telsasoft.com>
	<MN2PR15MB256016E33F00DE60B96F02D385E39@MN2PR15MB2560.namprd15.prod.outlook.com>
	<CAH2-Wzm3rSAWHyENb3T0X8M_qdYjF1t7rntkMJ2kDiuhVOHx3g@mail.gmail.com>
	<MN2PR15MB2560C1A890DC07F9359FB56285E39@MN2PR15MB2560.namprd15.prod.outlook.com>
	<732758.1626911007@sss.pgh.pa.us>
	<MN2PR15MB2560778595BB7AF6E691B26785E39@MN2PR15MB2560.namprd15.prod.outlook.com>
	<MN2PR15MB2560D429866BD65A70574A6C85E49@MN2PR15MB2560.namprd15.prod.outlook.com>
	<CAApHDvqoF7y7SQjGT=940njnAd_CUcUG6oRYChcP_+eJyuNiug@mail.gmail.com>
	<MN2PR15MB25603D3CE06C8F9C312EA58985E49@MN2PR15MB2560.namprd15.prod.outlook.com>
	<MN2PR15MB2560E4574A6E2B5AED2C03CB85E49@MN2PR15MB2560.namprd15.prod.outlook.com>
	<784576.1626968702@sss.pgh.pa.us>
	<785218.1626969409@sss.pgh.pa.us>
	<CAApHDvo+Gb80BVPKYCwHbLa7a7ZXp9ziq9URrpQaKdvXsd46bg@mail.gmail.com>
	<786600.1626970898@sss.pgh.pa.us>

I wrote:
> I think the right fix here is to remove the cap, which will require
> changing get_hash_mem to return double, and then maybe some cascading
> changes --- I've not looked at its callers.

Or, actually, returning size_t would likely make the most sense.
We'd fold the 1024L multiplier in here too instead of doing that
at the callers.

			regards, tom lane





view thread (59+ messages)  latest in thread

Message-ID: <786910.1626971210@sss.pgh.pa.us>
Permalink:  ../786910.1626971210@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/786910.1626971210@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, ldh@laurent-hasson.com, pg@bowt.ie, pryzby@telsasoft.com
  Subject: Re: Big performance slowdown from 11.2 to 13.3
  In-Reply-To: <786910.1626971210@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox