pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Erik Jones <erik@myemma.com>
Cc: Gregory Stark <stark@enterprisedb.com>
Cc: Douglas J Hunley <doug@hunley.homeip.net>
Cc: Jeff <threshar@threshar.is-a-geek.com>
Cc: Richard Huxton <dev@archonet.com>
Cc: pgsql-performance@postgresql.org
Subject: Re: 7 hrs for a pg_restore?
Date: Wed, 20 Feb 2008 11:54:06 -0500
Message-ID: <9755.1203526446@sss.pgh.pa.us> (raw)
In-Reply-To: <0C5E3C24-530F-40AD-8CB4-B0477A368F6E@myemma.com>
References: <200802191303.58840.doug@hunley.homeip.net>
	<200802191555.43340.doug@hunley.homeip.net>
	<080DA59E-2C02-4370-8584-FA7C8CC008B0@myemma.com>
	<200802200826.38611.doug@hunley.homeip.net>
	<874pc3ww96.fsf@oxford.xeocode.com>
	<0C5E3C24-530F-40AD-8CB4-B0477A368F6E@myemma.com>

Erik Jones <erik@myemma.com> writes:
> On Feb 20, 2008, at 8:14 AM, Gregory Stark wrote:
>> I would suggest leaving out the && which only obfuscate what's  
>> going on here.
>> 
>> PGOPTIONS=... pg_restore ...
>> 
>> would work just as well and be clearer about what's going on.

> Right, that's just an unnecessary habit of mine.

Isn't that habit outright wrong?  ISTM that with the && in there,
what you're doing is equivalent to

	PGOPTIONS=whatever
	pg_restore ...

This syntax will set PGOPTIONS for the remainder of the shell session,
causing it to also affect (say) a subsequent psql invocation.  Which is
exactly not what is wanted.

			regards, tom lane



view thread (42+ messages)  latest in thread

Message-ID: <9755.1203526446@sss.pgh.pa.us>
Permalink:  ../9755.1203526446@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/9755.1203526446@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: tgl@sss.pgh.pa.us, erik@myemma.com, stark@enterprisedb.com, doug@hunley.homeip.net, threshar@threshar.is-a-geek.com, dev@archonet.com
  Subject: Re: 7 hrs for a pg_restore?
  In-Reply-To: <9755.1203526446@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox