From: Grégoire de Turckheim <gdeturckheim@scaleway.com>
To: pgsql-performance@lists.postgresql.org
Subject: Re: Notifications within triggers seem to compromise performance
Date: Mon, 28 Oct 2019 17:35:22 +0100
Message-ID: <fbafc656-ca6f-0b94-7dff-37eeb937df7f@scaleway.com> (raw)
In-Reply-To: <24269.1572279925@sss.pgh.pa.us>
References: <2b617759-5c59-de3c-1de0-bed20d9c0db1@scaleway.com>
<15979.1572272524@sss.pgh.pa.us>
<1c0c95b4-01c4-bbbf-0e6e-f5d530e63ba0@scaleway.com>
<24269.1572279925@sss.pgh.pa.us>
Le 28/10/2019 à 17:25, Tom Lane a écrit :
> =?UTF-8?Q?Gr=c3=a9goire_de_Turckheim?= <gdeturckheim@scaleway.com> writes:
>> Le 28/10/2019 à 15:22, Tom Lane a écrit :
>>> We made some performance improvements for NOTIFY just a couple months
>>> ago, cf commits b10f40bf0, bb5ae8f6c, bca6e6435, 51004c717. It would
>>> be interesting to know how much those changes helped your use-case.
>> If my understanding of the problem is correct, there is no performance
>> issue with the notification itself.
>> The problem is the following: a system-wide lock is taken pre-commit, so
>> any other transaction with a NOTIFY will have to wait for other
>> transactions to complete before it can leave its own pre-commit stage.
> Right, but all commits are single-threaded at some granularity.
> The big problem with NOTIFY is that it sits for a long time holding
> that lock, if you have a lot of notify traffic. The commits I mentioned
> should improve that.
>
> Anyway, as I said, it would be good to find out whether the already
> finished fixes are enough to solve your problem, before we debate
> whether more needs to be done.
Let's do it this way, I'll give it a try (might be long, this isn't
something we can easily upgrade) and get back to you.
Thanks!
--
Grégoire de Turckheim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: gdeturckheim@scaleway.com, pgsql-performance@lists.postgresql.org
Subject: Re: Notifications within triggers seem to compromise performance
In-Reply-To: <fbafc656-ca6f-0b94-7dff-37eeb937df7f@scaleway.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox