public inbox for [email protected]  

help / color / mirror / Atom feed

From: Pop, Sebastian <[email protected]>
To: Christoph Berg <[email protected]>
Cc: PostgreSQL in Debian <[email protected]>
Cc: Saidi, Ali <[email protected]>
Cc: Csoma, Csaba <[email protected]>
Subject: Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64
Date: Thu, 11 Nov 2021 21:54:05 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

> Apply it, and run "make check-world" on focal. The others should be
> unaffected since the flag is on by default.

Here are the steps in my testing on focal - ubuntu 20.04:

git clone https://github.com/postgres/postgres
cd postgres
patch -p1 < a.diff
autoconf
make
make check-world

All checks passed on a c6g Graviton2 instance.

configure.in was renamed configure.ac in July 2020.
For older postgresql versions we need to patch configure.in.
See attached the patch a.diff that I used on trunk postgresql.

Thanks,
Sebastian

Attachments:

  [text/x-patch] a.diff (510B, 2-a.diff)
  download | inline diff:
--- a/configure.ac
+++ b/configure.ac
@@ -549,6 +549,10 @@ if test "$GCC" = yes -a "$ICC" = no; then
   if test -n "$NOT_THE_CFLAGS"; then
     CFLAGS="$CFLAGS -Wno-stringop-truncation"
   fi
+  if test x"$host_cpu" == x"aarch64"; then
+    PGAC_PROG_CC_CFLAGS_OPT([-moutline-atomics])
+    PGAC_PROG_CXX_CFLAGS_OPT([-moutline-atomics])
+  fi
 elif test "$ICC" = yes; then
   # Intel's compiler has a bug/misoptimization in checking for
   # division by NAN (NaN == 0), -mp1 fixes it, so add it to the CFLAGS.

view thread (26+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox