From: Christoph Berg <myon@debian.org>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-pkg-debian@postgresql.org
Subject: Re: amcheck packages
Date: Sat, 7 Oct 2017 22:10:06 +0200
Message-ID: <20171007201006.s5n2dr4oej4c7qnr@msg.df7cb.de> (raw)
In-Reply-To: <CAH2-Wz=c9OaU_Odiq36Fkht0D9xsshY6_pOtBjt-wM7Mo14Yug@mail.gmail.com>
References: <CAH2-WzmO++VVtDrY1FTiSy2cNdJdMvi2OjkR5eMgZU7h2O_1kg@mail.gmail.com>
<CAH2-Wz=dbV_vUBMUPA0Q7Eejxjt6HyTNRL4s1HVPSBf6yfUxVg@mail.gmail.com>
<CAH2-Wz=2K6_bUJcYjFCKqQEmDsCZFQrY1Dcvx5Szj7pwYDi6oQ@mail.gmail.com>
<20171003072437.zdptcl23kewltivh@msg.df7cb.de>
<20171005163525.7exvb5gx6c7d3nbd@msg.df7cb.de>
<CAH2-Wzk4O7rh0+QWGoX6Y8pmAfxim_9m7wE_popwo963O+X3zw@mail.gmail.com>
<20171005165552.awu2l6aoqzc5bepl@msg.df7cb.de>
<CAH2-WznctJz1ket8up3vDjLqxeEjM6x-MaOZe-iGsVai184cCg@mail.gmail.com>
<20171007100548.hqigo3xj7uxauqrp@msg.df7cb.de>
<CAH2-Wz=c9OaU_Odiq36Fkht0D9xsshY6_pOtBjt-wM7Mo14Yug@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-pkg-debian>
Re: Peter Geoghegan 2017-10-07 <CAH2-Wz=c9OaU_Odiq36Fkht0D9xsshY6_pOtBjt-wM7Mo14Yug@mail.gmail.com>
> >> Once this gets your approval, I'll push the commit to the master
> >> branch, and create the appropriate version 1.0 tags. Note that I've
> >> declared version 1.0 as being stable within debian/changelog.
Hi,
sorry I missed that part in the last round - the correct target in
debian/changelog is still "unstable" because that's where all the
uploads go before they trickle into testing and eventually get
released as stable. For apt.pg.o the target distribution doesn't
matter, though.
> The overhead of the tests, which only need to be simple smoke tests,
> is probably totally excessive. I've replaced the tests with the tests
> that actually made it into contrib/amcheck. The amcheck_next tests now
> complete in a couple of seconds, which will greatly reduce the burden
> on your Jenkins installation.
It now worked even on my crammed notebook SSD :)
> I've verified that they pass on all versions myself, and have pushed
> that to the master branch. I've also created release tags
> ("debian/1.0-1", and "v1.0").
I could download the tarball now and build packages. I've already
built them for apt.pg.o, and promoted them to the *-pgdg
distributions, they will appear on the mirrors in about half an hour.
For Debian, I made two small changes:
--- a/debian/changelog+++ b/debian/changelog-amcheck (1.0-1) stable; urgency=medium+amcheck (1.0-1) unstable; urgency=medium--- a/debian/control.in+++ b/debian/control.in-Standards-Version: 3.9.6+Standards-Version: 4.1.1
Maybe you could apply that, and possibly bump up the debian/1.0-1 tag
to reflect it (but that doesn't really matter much).
Is debian/pgversions intentionally not "9.4+"? We usually only list
explicit maximum versions if the newer versions are not supported on
purpose, and don't just "not work yet". (Though if the repo hosts both
upstream and debian/, that's probably ok.)
Thanks,
Christoph
--
Sent via pgsql-pkg-debian mailing list (pgsql-pkg-debian@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-debian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-pkg-debian@postgresql.org
Cc: myon@debian.org, pg@bowt.ie
Subject: Re: amcheck packages
In-Reply-To: <20171007201006.s5n2dr4oej4c7qnr@msg.df7cb.de>
References: <CAH2-WzmO++VVtDrY1FTiSy2cNdJdMvi2OjkR5eMgZU7h2O_1kg@mail.gmail.com> <CAH2-Wz=dbV_vUBMUPA0Q7Eejxjt6HyTNRL4s1HVPSBf6yfUxVg@mail.gmail.com> <CAH2-Wz=2K6_bUJcYjFCKqQEmDsCZFQrY1Dcvx5Szj7pwYDi6oQ@mail.gmail.com> <20171003072437.zdptcl23kewltivh@msg.df7cb.de> <20171005163525.7exvb5gx6c7d3nbd@msg.df7cb.de> <CAH2-Wzk4O7rh0+QWGoX6Y8pmAfxim_9m7wE_popwo963O+X3zw@mail.gmail.com> <20171005165552.awu2l6aoqzc5bepl@msg.df7cb.de> <CAH2-WznctJz1ket8up3vDjLqxeEjM6x-MaOZe-iGsVai184cCg@mail.gmail.com> <20171007100548.hqigo3xj7uxauqrp@msg.df7cb.de> <CAH2-Wz=c9OaU_Odiq36Fkht0D9xsshY6_pOtBjt-wM7Mo14Yug@mail.gmail.com> <20171007201006.s5n2dr4oej4c7qnr@msg.df7cb.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox