public inbox for [email protected]
help / color / mirror / Atom feedFrom: Huang Yuying <[email protected]>
To: Christoph Berg <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Request to Add New Package: pgsentinel
Date: Mon, 21 Jul 2025 22:55:28 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
Hi Christoph,
Thank you for your prompt response!
Regarding the build issue you mentioned, for testing, we manually downloaded the code from my GitHub repository (forked repo: https://github.com/laurahuang106/pgsentinel) instead of letting Debian pull it using the watch file.
The Makefile is not yet in the upstream repository. As mentioned in the previous email, we made some changes to the source code, and pushed to my forked repo. Does anyone here think it might be better to add the '--sourcedirectory=src' suffix to all overrides in the debian/rules file instead of creating a top-level Makefile?
Please let me know if you have any questions or suggestions. Thank you!
Sincerely,
Laura
------------------------------------------------------------------------------------------------------------------------------
On 7/21/25, 13:06, "Christoph Berg" <[email protected] <mailto:[email protected]>> wrote:
Re: Huang Yuying
> The packaging code is publicly available at: https://salsa.debian.org/laurah159/pgsentinel/ <https://salsa.debian.org/laurah159/pgsentinel/;.
>
> To support packaging, we made the following changes to the upstream pgsentinel code:
>
> 1. Added a top-Level Makefile
Hi,
this doesn't to be present yet in the 1.1.0 tarball. How did you
invoke the build such that it actually worked?
$ dpkg-buildpackage -rfakeroot -us -uc -i -I -j20
dpkg-buildpackage: info: source package pgsentinel
dpkg-buildpackage: info: source version 1.1.0-1
dpkg-buildpackage: info: source distribution UNRELEASED
dpkg-buildpackage: info: source changed by Laura H. <[email protected] <mailto:[email protected]>>
dpkg-buildpackage: info: host architecture amd64
dpkg-source -i -I --before-build .
debian/rules clean
dh clean --with pgxs_loop
dh_auto_clean --buildsystem=pgxs_loop
pg_buildext clean build-%v postgresql-%v-pgsentinel
rm -rf build-*/
rm -rf debian/postgresql-17-pgsentinel/ debian/postgresql-*-pgsentinel.substvars
dh_clean
pg_buildext checkcontrol
dpkg-source -i -I -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building pgsentinel using existing ./pgsentinel_1.1.0.orig.tar.gz
dpkg-source: info: building pgsentinel in pgsentinel_1.1.0-1.debian.tar.xz
dpkg-source: info: building pgsentinel in pgsentinel_1.1.0-1.dsc
debian/rules binary
dh binary --with pgxs_loop
dh_update_autotools_config
dh_autoreconf
dh_auto_build --buildsystem=pgxs_loop
create-stamp debian/debhelper-build-stamp
dh_prep
dh_auto_install --buildsystem=pgxs_loop --destdir=debian/postgresql-17-pgsentinel/
pg_buildext loop postgresql-%v-pgsentinel
### PostgreSQL 17 loop ###
# 17: make
make[1]: Entering directory '/home/myon/projects/postgresql/pgsentinel/pgsentinel'
make[1]: *** No targets specified and no makefile found. Stop.
make[1]: Leaving directory '/home/myon/projects/postgresql/pgsentinel/pgsentinel'
### End 17 loop (FAILED with exit code 2) ###
dh_auto_install: error: pg_buildext loop postgresql-%v-pgsentinel returned exit code 2
make: *** [debian/rules:10: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
> By the way, in the debian/control.in file, is it possible to add two uploaders? Jeremy will probably be the ongoing maintainer, and I would like to include him as an uploader.
It's a comma-separated list.
Christoph
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Request to Add New Package: pgsentinel
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox