public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bertrand Drouvot <[email protected]>
To: Christoph Berg <[email protected]>
To: Huang Yuying <[email protected]>
To: [email protected] <[email protected]>
To: Jeremy Schneider <[email protected]>
Subject: Re: Request to Add New Package: pgsentinel
Date: Thu, 31 Jul 2025 05:04:05 +0000
Message-ID: <aIr5RYlvKYGhh5U/@ip-10-97-1-34.eu-west-3.compute.internal> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<SA1PR02MB8608ACD0EE5A90574B3C97688724A@SA1PR02MB8608.namprd02.prod.outlook.com>
	<[email protected]>

Hi,

On Wed, Jul 30, 2025 at 04:53:16PM +0200, Christoph Berg wrote:
> Re: Huang Yuying
> > Just wanted to give you a quick update that a new version of pgsentinel has been released with the changes needed to support the Debian build process, as mentioned in the previous email. We’ve also updated the Salsa repo to reflect this new release.

Thanks for doing this!

> Hi,
> 
> thanks for preparing that, everything looks just fine and I already
> built and uploaded the packages.
> 
> The repo is now located at https://salsa.debian.org/postgresql/pgsentinel,
> I gave you maintainer access to it.
> 
> First bugreport: PG18 doesn't work yet :)

Thanks for the report! ;-)

> 16:45:03 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -Wmissing-variable-declarations -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -Werror=implicit-function-declaration -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fno-omit-frame-pointer -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fPIC -fvisibility=hidden -std=c99 -Wall -Wextra -Werror -Wno-unused-parameter -Wno-implicit-fallthrough -Iinclude -I. -I./ -I/usr/include/postgresql/18/server -I/usr/include/postgresql/internal    -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o pgsentinel.o pgsentinel.c
> 16:45:03 pgsentinel.c:77:7: error: no previous declaration for ‘pgsentinelDbName’ [-Werror=missing-variable-declarations]
> 16:45:03    77 | char *pgsentinelDbName = "postgres";
> 16:45:03       |       ^~~~~~~~~~~~~~~~
> 16:45:03 cc1: all warnings being treated as errors
> 

Just pushed a fix.

Best,
Bertrand

view thread (7+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Request to Add New Package: pgsentinel
  In-Reply-To: <aIr5RYlvKYGhh5U/@ip-10-97-1-34.eu-west-3.compute.internal>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox