public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrey Borodin <[email protected]>
To: Christoph Berg <[email protected]>
Cc: [email protected]
Subject: Re: Adding packages fro WAL-G and Odyssey
Date: Mon, 6 Dec 2021 12:09:55 +0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>



> 5 июля 2021 г., в 21:25, Christoph Berg <[email protected]> написал(а):
> 
> Re: Andrey Borodin
>>> we'd need a proper debian/ directory for these, either in the upstream
>>> repo or in a separate one.
>> Odyssey had debian/ dir https://github.com/yandex/odyssey/tree/master/scripts/debian
> 
> Hi,
> 
> that directory would need to be /debian, not somewhere deeper in the
> tree. (Interestingly, you already have a /debian, just with less
> files.)
> 
>> WAL-G is simply one Go binary. https://github.com/wal-g/wal-g/tree/master/cmd/pg
>> Though it's a separate Go binary for each DB: PG, MySQL, MSSQL, MongoDB etc. But I think it's better to start from PG anyway.
>> We used to build this binary and create almost empty debian/ dir with a script (FPA). We can commit this dir it it's better to have it in source tree.
> 
> FPA usually doesn't produce "proper" packages with a curated
> debian/changelog (no throwing away of old entries, and sensible log
> messages) and the other bits.
> 
> debian/rules shouldn't try to build a -dbg package these days
> 
> debian/control shouldn't depend on postgresql-server-dev-13 but on
> postgresql-server-dev-all if you really need server headers instead of
> just the client ones.
> 
> The Description needs more content
> 
> Standards-Version is outdated
> 
> Consider using debhelper-compat (= 13) instead of debian/compat 9
> 
> Consider providing a systemd .service file along the init script

Thanks, Christoph!
We have updated /debian stuff in Odyssey. Can you please take a look again?
https://github.com/yandex/odyssey/pull/372/files

Best regards, Andrey Borodin.

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Adding packages fro WAL-G and Odyssey
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox