Re: Packaging request MobilityDB

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Bradford Boyle <[email protected]>
To: Esteban Zimanyi <[email protected]>
Cc: [email protected]
Subject: Re: Packaging request MobilityDB
Date: Sun, 4 Jun 2023 19:37:05 -0700
Message-ID: <CAOMoQbQPOs827ZNk2atm0JHQYDJ4iW339a8HxovxUZzpa4RjtA@mail.gmail.com> (raw)
In-Reply-To: <CAOMoQbRMo5HM4eMsUmcQ+5_eGUZK6zycMgifnEehbooee+L5HA@mail.gmail.com>
References: <CAPqRbE716D3gpD0JDbaFAb72ELaJrPpG1LUZvobELNBgL3R0+g@mail.gmail.com>
	<CAOMoQbRMo5HM4eMsUmcQ+5_eGUZK6zycMgifnEehbooee+L5HA@mail.gmail.com>

I've spent some time looking at packaging MobilityDB for inclusion in
the Debian archive and PGDG. Here is a high-level summary of what I've
done so far:

* Opened an ITP bug against wnpp for MobilityDB [1]
* Created an initial source package with dh make_pgxs
  - Replaced default autopkgtest with customized one (see below for
    discussion)
* Created a new project on salsa under the PostgreSQL team [2]
  - I have not updated the CI/CD settings to point at d/gitlab-ci.yml
    (see below for discussion)
* Added a job for MobilityDB to the pgapt Jenkins jobs (patch attached)

Upstream isn't using pgxs for its build system and does not have an
installcheck target. The build system does have tests but these tests
are run with cmake and running that in autopkgtest would require
re-building the source package (or using the 'build-needed'
restriction). Additionally, the upstream tests include creating,
starting, and stoping a test cluster. I decided to replace the generated
'installcheck' script with a custom one that uses pg_virtualenv and
pg_regress to run upstream's test cases. I was able to (automatically)
reuse the test SQL queries from upstream but I was not able to reuse the
expected responses. This is because upstream's test uses UTC timezone
while pg_regress sets PGTZ to PST8PDT. Additionally, upstream's test
includes pre- and post-processing of the expected results to standardize
ERROR messages along with removing WARNING and CONTEXT lines. I have had
to skip one test case (052_tpoint.test) because it is currently failing
with the following error message in the Postgres log:

> *** stack smashing detected ***: terminated
> 2023-06-04 02:59:18.383 UTC [25831] LOG:  server process (PID 25852) was terminated by signal 6: Aborted
> 2023-06-04 02:59:18.383 UTC [25831] DETAIL:  Failed process was running: SELECT tgeompoint(Instant,PointZ,5676,1234) 'SRID=5676;Point(0 0 0)@2000-01-01';

I think this indicates a potential buffer overflow bug [3] but I haven't
had a chance to look into it.

I have skipped setting up the CI/CD settings for the packaging
repository on Salsa for now. The intent is to package the upcoming
release of MobilityDB 1.1 and since the release hasn't happened yet,
there is no upstream source archive to fetch with uscan. For my local
development and testing of the package, I've just used a "fake" source
archive that I created with git archive. Until the upstream release of
1.1, I'd expect the default GitLab pipeline to fail. This is why I have
added the package to pgapt's Jenkins jobs with the job group of
"git+upstream-snapshot".

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037101
[2]: https://salsa.debian.org/postgresql/mobilitydb
[3]: https://stackoverflow.com/a/1347464

Attachments:

  [application/octet-stream] 0001-Add-MobilityDB.patch (1.5K, 2-0001-Add-MobilityDB.patch)
  download | inline diff:
From 0eba5e1c144e8d4bff76db0a360d8465e42c4c53 Mon Sep 17 00:00:00 2001
From: "Bradford D. Boyle" <[email protected]>
Date: Sun, 4 Jun 2023 19:27:17 -0700
Subject: [PATCH] Add MobilityDB

---
 jenkins/packages           | 1 +
 jenkins/packages.betatests | 1 +
 jenkins/pgapt-jobs.yaml    | 9 +++++++++
 3 files changed, 11 insertions(+)

diff --git a/jenkins/packages b/jenkins/packages
index 7170113..4afded4 100644
--- a/jenkins/packages
+++ b/jenkins/packages
@@ -23,6 +23,7 @@ libstringprep-java
 libtap-parser-sourcehandler-pgtap-perl
 londiste
 mimeo
+mobilitydb
 omnidb
 omnidb-plpgsql-debugger
 ora2pg
diff --git a/jenkins/packages.betatests b/jenkins/packages.betatests
index d814659..f20f1a6 100644
--- a/jenkins/packages.betatests
+++ b/jenkins/packages.betatests
@@ -23,6 +23,7 @@ libstringprep-java
 libtap-parser-sourcehandler-pgtap-perl
 londiste
 mimeo
+mobilitydb
 omnidb
 omnidb-plpgsql-debugger
 ora2pg
diff --git a/jenkins/pgapt-jobs.yaml b/jenkins/pgapt-jobs.yaml
index bab0bf9..fb17edf 100644
--- a/jenkins/pgapt-jobs.yaml
+++ b/jenkins/pgapt-jobs.yaml
@@ -1149,6 +1149,15 @@
         jobs:
                 - git-packages-with-beta

+- project:
+        name: mobilitydb
+        git-url: https://salsa.debian.org/postgresql/mobilitydb.git
+        git-branch: main
+        upstream-url: https://github.com/MobilityDB/MobilityDB.git
+        upstream-branch: develop
+        jobs:
+                - git+upstream-snapshot
+
 - project:
         name: omnidb
         git-url: https://salsa.debian.org/postgresql/omnidb.git
-- 
2.41.0

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Packaging request MobilityDB
  In-Reply-To: <CAOMoQbQPOs827ZNk2atm0JHQYDJ4iW339a8HxovxUZzpa4RjtA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox