public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bradford Boyle <[email protected]>
To: Brian Cosgrove <[email protected]>
Cc: [email protected]
Subject: Re: PgBouncer 1.24.0 - New upstream version
Date: Sun, 12 Jan 2025 20:13:51 -0800
Message-ID: <CAOMoQbROhu7WG9LnyjHb1RXJrax_HKKMBbwaou+jps0uZgqHFw@mail.gmail.com> (raw)
In-Reply-To: <CAGKCzNBZO-AQMfmbfbn20wvE+63j50YuPBKJupYLiDCmc84OeA@mail.gmail.com>
References: <CAOMoQbT0VmMZFRA68Geff9MScuGRTwokCf81O-0dqja8hmjNpQ@mail.gmail.com>
	<CAGKCzNBZO-AQMfmbfbn20wvE+63j50YuPBKJupYLiDCmc84OeA@mail.gmail.com>

Hi Brian,

On Sun, Jan 12, 2025 at 4:47 AM Brian Cosgrove <[email protected]> wrote:
>
> Unrelated to autopkgtest, I noticed in October that during debbuild
> the package does not run the main pytest suite for pgbouncer? Is that
> intentional? It appears that before the tests were rewritten in python
> that the package ran the shell-based suite properly.

Looking at the history for d/rules, I think disabling the main test
suite during the build was intended to be a temporary fix for a missing
file in the upstream source archive [0],[1]. It looks like the tests
weren't re-enabled when the issue was fixed upstream.

> I submitted a patch that should be able to be incorporated as-is:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1085109

I've applied your patch to the package and pushed the changes to Salsa.
I did have to drop the b-d on python3-contextlib2 since this package is
not available (and not needed) in unstable. I also had to add
tzdata-legacy in order for the tests to pass. We'll probably need to add
some tweaks for the pgdg packages to build on older distributions.

[0]: https://salsa.debian.org/postgresql/pgbouncer/-/commit/74f05a0#8756c63497c8dc39f7773438edf53b220c773...
[1]: https://github.com/pgbouncer/pgbouncer/issues/431

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: PgBouncer 1.24.0 - New upstream version
  In-Reply-To: <CAOMoQbROhu7WG9LnyjHb1RXJrax_HKKMBbwaou+jps0uZgqHFw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox