public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bradford Boyle <[email protected]>
To: David Steele <[email protected]>
Cc: Christoph Berg <[email protected]>
Cc: [email protected]
Subject: Re: pgBackRest 2.52 - New upstream version
Date: Mon, 3 Jun 2024 20:36:17 -0700
Message-ID: <CAOMoQbT04hcG90CYqYp3X7V+DzZ0iec28KV6AffUvFDkWmai5g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAOMoQbTzXVT+LhShQW4uQpwmp5kGrhWCPincsrSvd3S1Qn16UA@mail.gmail.com>
<CAOMoQbQkL6yDJB2-vZur0S1uiuuzh6KqtdoxhtVEHfqLaeJcGQ@mail.gmail.com>
<[email protected]>
<CAOMoQbT0rewgfaLNah69MLCkieKBBVD3V_DH5QpzGd5gq9RpyA@mail.gmail.com>
<[email protected]>
Hi David and Christoph,
> This is actually a bug/typo in older versions of meson. What is actually
> required (in some cases) is python3-distutils.
I found [this issue][1] on GitHub repo for meson which indicates that
meson 0.48.0 added a dependency on python's setuptools module. This
issue is quite old but it was referenced by a [newer pull request][2]
that seems to indicate that at some point meson depended on python's
distutils module. This PR was referenced by an even [newer PR][3] that
seems to indicate that meson moved away from using the distutils module.
This is probably why this is only an issue in bullseye or focal and not
older or newer dists.
> It's a bit of a mess, but looks like we need to install
> python3-distutils just for bullseye and focal as a build dependency. Is
> that possible?
Adding python3-distutils for just bullseye and focal should be doable. I
believe the scripts used to build the packages for the PGDG apt repo has
an existing pattern for tweaking the package. Attached is a patch that
should add python3-distutils to pgbackrest's list of build dependencies
only on bullseye or focal.
--Bradford
[1]: https://github.com/mesonbuild/meson/issues/4267
[2]: https://github.com/mesonbuild/meson/pull/9288
[3]: https://github.com/mesonbuild/meson/pull/11133
Attachments:
[application/octet-stream] 0001-pgbackrest-Add-python3-distutils-dependency.patch (873B, 2-0001-pgbackrest-Add-python3-distutils-dependency.patch)
download | inline diff:
From 76f9b37c9eec2cd0e778e566363dea5f6c2e8784 Mon Sep 17 00:00:00 2001
From: "Bradford D. Boyle" <[email protected]>
Date: Mon, 3 Jun 2024 20:31:12 -0700
Subject: [PATCH] pgbackrest: Add python3-distutils dependency
---
jenkins/generate-pgdg-source | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/jenkins/generate-pgdg-source b/jenkins/generate-pgdg-source
index 151b1cd..6b5791a 100755
--- a/jenkins/generate-pgdg-source
+++ b/jenkins/generate-pgdg-source
@@ -290,6 +290,15 @@ case $PACKAGE in
esac
;;
+ pgbackrest)
+ case $distribution in
+ bullseye|focal)
+ sed -i -E 's/( +)(pkgconf,)/\1\2\n\1python3-distutils,/' debian/control
+ TWEAK+=("Add python3-distutils dependency")
+ ;;
+ esac
+ ;;
+
postgis)
case ${distribution:-} in
buster|stretch|focal|eoan|bionic|xenial)
--
2.45.2
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgBackRest 2.52 - New upstream version
In-Reply-To: <CAOMoQbT04hcG90CYqYp3X7V+DzZ0iec28KV6AffUvFDkWmai5g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox