public inbox for [email protected]  

help / color / mirror / Atom feed

From: Christoph Berg <[email protected]>
To: Devrim Gündüz <[email protected]>
Cc: Regina Obe <[email protected]>
Cc: [email protected]
Subject: Re: Include h3-pg extension
Date: Sun, 5 Nov 2023 12:02:13 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

Re: Devrim Gündüz
> There are some overlapping files between h3 and h3-pg. I did not check
> closely, but you may not have to package h3. Just a FYI.

It took me a while to figure out because it was hidden in an
unexpected location, but the reason h3-pg can be compiled without h3
is that it downloads it at build time:

CMakeLists.txt:
# Include core library
add_subdirectory(cmake/h3)

cmake/h3/CMakeLists.txt:
FetchContent_Declare(
  h3
  URL      https://github.com/uber/h3/archive/refs/tags/v${H3_CORE_VERSION}.tar.gz
  URL_HASH SHA256=${H3_CORE_SHA256}
)
FetchContent_MakeAvailable(h3)

Deleting the line from CMakeLists.txt made it properly use the
system-installed libh3.

Regina: postgresql-NN-h3 packages are in the repository.

Christoph

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Include h3-pg extension
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox