pg.ddx.io  pgsql-pkg-debian@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Chapman Flack <chap@anastigmatix.net>
To: Devrim Gündüz <devrim@gunduz.org>
To: pgsql-pkg-yum@postgresql.org
Subject: Re: PL/Java 1.5.2 - fixes one regression in date conversion in 1.5.1
Date: Tue, 26 Feb 2019 16:18:56 -0500
Message-ID: <b2b0549c-fb47-c5b0-4e22-54d5df493fed@anastigmatix.net> (raw)
In-Reply-To: <aa0af7be64187cda33e9346c023bc2e88f97ad38.camel@gunduz.org>
References: <5BE08D74.2060207@anastigmatix.net>
	<5C2AF4F6.6070606@anastigmatix.net>
	<1e2d8a7a9a2e870cf39eec61a8c2a4eb5cc70c32.camel@gunduz.org>
	<214c9f2f-423f-39ff-2477-887567c400db@anastigmatix.net>
	<1a0711f4b5b1304f1d3031251cbe4efcfffccd28.camel@gunduz.org>
	<6e8c6808-601b-baf5-865b-8c1785cfe346@anastigmatix.net>
	<9c7756dd-bab5-4978-cc93-d0a4a6f0b605@anastigmatix.net>
	<5C374DB5.20001@anastigmatix.net>
	<40eeb475-b996-d33c-edcf-775a0118b341@anastigmatix.net>
	<aa0af7be64187cda33e9346c023bc2e88f97ad38.camel@gunduz.org>

On 2/26/19 2:16 PM, Devrim Gündüz wrote:
> How does it look now?
> 
> # ll *sql
> lrwxrwxrwx 1 root root   39 Feb 26 22:13 pljava--1.5.0--1.5.1.sql -> /usr/pgsql-11/share/pljava/pljava--.sql
> lrwxrwxrwx 1 root root   39 Feb 26 22:13 pljava--1.5.0-BETA1--1.5.1.sql -> /usr/pgsql-11/share/pljava/pljava--.sql
> lrwxrwxrwx 1 root root   39 Feb 26 22:13 pljava--1.5.0-BETA2--1.5.1.sql -> /usr/pgsql-11/share/pljava/pljava--.sql
> lrwxrwxrwx 1 root root   39 Feb 26 22:13 pljava--1.5.0-BETA3--1.5.1.sql -> /usr/pgsql-11/share/pljava/pljava--.sql
> lrwxrwxrwx 1 root root   39 Feb 26 22:13 pljava--1.5.1--1.5.2.sql -> /usr/pgsql-11/share/pljava/pljava--.sql
> lrwxrwxrwx 1 root root   39 Feb 26 22:13 pljava--1.5.1-BETA1--1.5.1.sql -> /usr/pgsql-11/share/pljava/pljava--.sql
> lrwxrwxrwx 1 root root   39 Feb 26 22:13 pljava--1.5.1-BETA2--1.5.1.sql -> /usr/pgsql-11/share/pljava/pljava--.sql
> lrwxrwxrwx 1 root root   39 Feb 26 22:13 pljava--1.5.1-BETA3--1.5.1.sql -> /usr/pgsql-11/share/pljava/pljava--.sql
> -rw-r--r-- 1 root root 3228 Feb 26 22:13 pljava--1.5.2.sql
> -rw-r--r-- 1 root root 2433 Feb 26 22:13 pljava--.sql
> -rw-r--r-- 1 root root 3580 Feb 26 22:13 pljava--unpackaged--1.5.2.sql

Hi Devrim,

Thanks for taking a look ... that's better, with one complication, though.

It has links for updating 150-BETA* to 150, 151-BETA* and 150 to 151,
151-BETA* and 151 to 152, which would be the typical arrangement for a
typical extension, and would cause PostgreSQL to automatically apply
multiple scripts in sequence.

The multiple script sequence won't work in PL/Java though, because
the updating work is really done inside PL/Java at its own startup,
which can't be repeated over a single backend connection.
(You have seen that they are all links to one script, which does
nothing but store the library pathname and exnihilo=false (indicating
update) in a table and LOAD the library, which unconditionally applies
any schema updates needed to match its own version. PostgreSQL itself
treats later LOADs of the same library as no-ops, so I couldn't
make the multiple-script sequence work if I wanted to).

This is sort of an imperfect fit with the PG extension conventions,
but PL/Java 1.5.x still supports PG versions older than the extension
feature, so updating has to be easy for them too.

So the intent for packaging is to include a link pljava--foo--1.5.2.sql
for every plausible prior version foo, so PostgreSQL will choose
a one-script update path no matter which prior version is installed.

The actual files placed into an "official" build can be found
starting here:

https://github.com/tada/pljava/blob/REL1_5_STABLE/pljava-packaging/build.xml#L280

Thanks!
-Chap




view thread (20+ messages)  latest in thread

Message-ID: <b2b0549c-fb47-c5b0-4e22-54d5df493fed@anastigmatix.net>
Permalink:  ../b2b0549c-fb47-c5b0-4e22-54d5df493fed@anastigmatix.net/
Also on:    postgresql.org/message-id/b2b0549c-fb47-c5b0-4e22-54d5df493fed@anastigmatix.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-pkg-debian@postgresql.org
  Cc: chap@anastigmatix.net, devrim@gunduz.org, pgsql-pkg-yum@postgresql.org
  Subject: Re: PL/Java 1.5.2 - fixes one regression in date conversion in 1.5.1
  In-Reply-To: <b2b0549c-fb47-c5b0-4e22-54d5df493fed@anastigmatix.net>
  References: <5BE08D74.2060207@anastigmatix.net> <5C2AF4F6.6070606@anastigmatix.net> <1e2d8a7a9a2e870cf39eec61a8c2a4eb5cc70c32.camel@gunduz.org> <214c9f2f-423f-39ff-2477-887567c400db@anastigmatix.net> <1a0711f4b5b1304f1d3031251cbe4efcfffccd28.camel@gunduz.org> <6e8c6808-601b-baf5-865b-8c1785cfe346@anastigmatix.net> <9c7756dd-bab5-4978-cc93-d0a4a6f0b605@anastigmatix.net> <5C374DB5.20001@anastigmatix.net> <40eeb475-b996-d33c-edcf-775a0118b341@anastigmatix.net> <aa0af7be64187cda33e9346c023bc2e88f97ad38.camel@gunduz.org> <b2b0549c-fb47-c5b0-4e22-54d5df493fed@anastigmatix.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox