public inbox for [email protected]
help / color / mirror / Atom feedFix for pgbackrest systemd service file
4+ messages / 3 participants
[nested] [flat]
* Fix for pgbackrest systemd service file
@ 2022-07-26 17:21 Don Seiler <[email protected]>
2022-07-26 22:37 ` Re: Fix for pgbackrest systemd service file David Steele <[email protected]>
2022-07-26 23:01 ` Re: Fix for pgbackrest systemd service file Don Seiler <[email protected]>
2022-07-27 07:02 ` Re: Fix for pgbackrest systemd service file Adrian Vondendriesch <[email protected]>
0 siblings, 3 replies; 4+ messages in thread
From: Don Seiler @ 2022-07-26 17:21 UTC (permalink / raw)
To: pgsql-pkg-debian; +Cc: David Steele <[email protected]>
Good afternoon,
I was talking with David Steele and pointed out errors I saw in the
pgbackrest service file when doing some early TLS file. It looks like the
errors stem from line 15 where the kill command doesn't have the absolute
path, and should be /bin/kill. I confirmed the errors go away when I
specify the full path to the kill binary.
I've given David this info and he is updating their documentation to
reflect the change also.
Before:
$ sudo systemctl status pgbackrest
● pgbackrest.service - pgBackRest Server
Loaded: loaded (/lib/systemd/system/pgbackrest.service; disabled; vendor
preset: enabled)
Active: inactive (dead)
Jul 19 16:37:44 postgres-history0-az-eastus2 systemd[1]:
/lib/systemd/system/pgbackrest.service:15: Executable path is not absolute:
kill -HUP $MAINPID
After:
$ sudo systemctl status pgbackrest
● pgbackrest.service - pgBackRest Server
Loaded: loaded (/lib/systemd/system/pgbackrest.service; disabled; vendor
preset: enabled)
Active: inactive (dead)
Diff on an Ubuntu 18.04 system:
$ sudo diff -u pgbackrest.service.old /lib/systemd/system/pgbackrest.service
--- pgbackrest.service.old 2022-07-26 17:19:37.321260963 +0000
+++ /lib/systemd/system/pgbackrest.service 2022-07-26
15:34:51.100155390 +0000
@@ -12,7 +12,7 @@
ExecStart=/usr/bin/pgbackrest server
ExecStartPost=/bin/sleep 3
ExecStartPost=/bin/bash -c "[ ! -z $MAINPID ]"
-ExecReload=kill -HUP $MAINPID
+ExecReload=/bin/kill -HUP $MAINPID
[Install]
WantedBy=multi-user.target
--
Don Seiler
www.seiler.us
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Fix for pgbackrest systemd service file
2022-07-26 17:21 Fix for pgbackrest systemd service file Don Seiler <[email protected]>
@ 2022-07-26 22:37 ` David Steele <[email protected]>
2 siblings, 0 replies; 4+ messages in thread
From: David Steele @ 2022-07-26 22:37 UTC (permalink / raw)
To: Don Seiler <[email protected]>; pgsql-pkg-debian
On 7/26/22 13:21, Don Seiler wrote:
>
> I was talking with David Steele and pointed out errors I saw in the
> pgbackrest service file when doing some early TLS file. It looks like
> the errors stem from line 15 where the kill command doesn't have the
> absolute path, and should be /bin/kill. I confirmed the errors go away
> when I specify the full path to the kill binary.
>
> I've given David this info and he is updating their documentation to
> reflect the change also.
Done here
https://github.com/pgbackrest/pgbackrest/commit/e9ff5248039eedb25da2fee550ec64fcebbc51c7
and updated the online documentation.
Thanks!
-David
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Fix for pgbackrest systemd service file
2022-07-26 17:21 Fix for pgbackrest systemd service file Don Seiler <[email protected]>
@ 2022-07-26 23:01 ` Don Seiler <[email protected]>
2 siblings, 0 replies; 4+ messages in thread
From: Don Seiler @ 2022-07-26 23:01 UTC (permalink / raw)
To: pgsql-pkg-debian; +Cc: David Steele <[email protected]>
On Tue, Jul 26, 2022 at 12:21 PM Don Seiler <[email protected]> wrote:
>
> Before:
>
> $ sudo systemctl status pgbackrest
> ● pgbackrest.service - pgBackRest Server
> Loaded: loaded (/lib/systemd/system/pgbackrest.service; disabled;
> vendor preset: enabled)
> Active: inactive (dead)
>
Just noticed I pasted the wrong clip here for the "Before" example. This
should show that there's a failure to load with a formatting error
specified. I'll try to get the actual text later, I'm not at my workstation
at the moment.
--
Don Seiler
www.seiler.us
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Fix for pgbackrest systemd service file
2022-07-26 17:21 Fix for pgbackrest systemd service file Don Seiler <[email protected]>
@ 2022-07-27 07:02 ` Adrian Vondendriesch <[email protected]>
2 siblings, 0 replies; 4+ messages in thread
From: Adrian Vondendriesch @ 2022-07-27 07:02 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
Hi Don,
Am 26.07.22 um 19:21 schrieb Don Seiler:
> Good afternoon,
>
> I was talking with David Steele and pointed out errors I saw in the
> pgbackrest service file when doing some early TLS file. It looks like
> the errors stem from line 15 where the kill command doesn't have the
> absolute path, and should be /bin/kill. I confirmed the errors go away
> when I specify the full path to the kill binary.
>
> I've given David this info and he is updating their documentation to
> reflect the change also.
Thanks for reporting this issue. The fix will be included in the next
package update.
Cheers,
- Adrian
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2022-07-27 07:02 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-26 17:21 Fix for pgbackrest systemd service file Don Seiler <[email protected]>
2022-07-26 22:37 ` David Steele <[email protected]>
2022-07-26 23:01 ` Don Seiler <[email protected]>
2022-07-27 07:02 ` Adrian Vondendriesch <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox