public inbox for [email protected]  
help / color / mirror / Atom feed
From: Devrim Gündüz <[email protected]>
To: Martín Marqués <[email protected]>
To: pgsql-pkg-yum <[email protected]>
Subject: Re: patch bug in 9.6 spec
Date: Sat, 22 Jul 2017 10:59:42 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-pkg-yum>


Hi Martin,

On Thu, 2017-07-06 at 22:16 -0300, Martín Marqués wrote:
> I was making a custom build with a patch for 9.6 and found this which
> seems to be a bug in the spec file of postgresql 9.6.3 src.rpm package:
> 
> %patch6 -p1
> %if 0%{?rhel} && 0%{?rhel} <= 5
> %patch7 -p1
> %endif
> 
> Compilation passed because I'm using rhel7, but that patch doesn't exist
> in the spec file, so if someone would have tried to compile it on rhel5
> it would have failed.
> 
> I didn't do much digging on when it got there, but it seems it would be
> good to remove it.

I think you are using an older version of the spec file -- this is from 9.6.3-2 
changelog:

- Remove nonexistent Patch7 reference

I refactored the spec files recently, so please let me know if you see more
issues.

Regards,
-- 
Devrim Gündüz
EnterpriseDB: https://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: patch bug in 9.6 spec
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox