public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew N Golovkov <[email protected]>
To: Jeff Frost <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: init script for pgpool
Date: Sat, 19 Sep 2015 01:26:35 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-pkg-yum>
git diff -b: https://bpaste.net/show/89b37acb8f0a
Removed `switch' action, because not supported at least from 3.3.3, where init-script changed in upstream;
Every call stop/start/reload with correct calls and use variable `$PGPOOLUSER'
Removed unhandled arguments from `failure' and `success' function calls;
Cleanup useless commands and exit's.
Every line aligned with tabs;
Version in comment is 3.4 as proposed Devrim.
19.09.2015, 00:50, "Jeff Frost" <[email protected]>:
> Could you use diff -b so it doesn’t show lines with just whitespace different?
>
>> On Sep 18, 2015, at 2:46 PM, Andrew N Golovkov <[email protected]> wrote:
>>
>> And again.
>>
>> https://bpaste.net/show/20ee48a0fc81
>>
>> Diff with your script and my (with little cosmetic changes from previous version).
>>
>> 18.09.2015, 23:45, "Jeff Frost" <[email protected]>:
>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>
>>>> On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <[email protected]> wrote:
>>>>
>>>> You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
>>>> Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
>>>>> $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
>>>>
>>>> Please, look at my script i'v posted today.
>>>>
>>>> 18.09.2015, 20:17, "Jeff Frost" <[email protected]>:
>>>>> Nice catch! I found a couple other things as well, so here’s an updated version:
>>>>>
>>>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>>>
>>>>> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>>>>>
>>>>>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>>>>>>
>>>>>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>>>>>
>>>>>> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>>>>>> --
>>>>>> Sent via pgsql-pkg-yum mailing list ([email protected])
>>>>>> To make changes to your subscription:
>>>>>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>>>>
>>>>> ---
>>>>> Jeff Frost <[email protected]>
>>>>> CTO, PostgreSQL Experts, Inc.
>>>>> Phone: 1-888-PG-EXPRT x506
>>>>> FAX: 415-762-5122
>>>>> http://www.pgexperts.com/
>>>
>>> ---
>>> Jeff Frost <[email protected]>
>>> CTO, PostgreSQL Experts, Inc.
>>> Phone: 1-888-PG-EXPRT x506
>>> FAX: 415-762-5122
>>> http://www.pgexperts.com/
>
> ---
> Jeff Frost <[email protected]>
> CTO, PostgreSQL Experts, Inc.
> Phone: 1-888-PG-EXPRT x506
> FAX: 415-762-5122
> http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
view thread (22+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: init script for pgpool
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox