public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Devrim Gündüz <[email protected]>
Cc: [email protected]
Subject: Re: pgbouncer logrotate configuration
Date: Tue, 22 Sep 2015 14:51:53 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-pkg-yum>

On 5/13/15 4:55 PM, Peter Eisentraut wrote:
> On 5/12/15 5:24 PM, Devrim Gündüz wrote:
>>
>> Hi,
>>
>> On Tue, 2015-05-12 at 10:44 -0400, Peter Eisentraut wrote:
>>> The pgbouncer logrotate configuration seems a bit contradictory:
>>>
>>> /var/log/pgbouncer.log {
>>>     missingok
>>>     notifempty
>>>     sharedscripts
>>>     copytruncate
>>>     create 0640 pgbouncer pgbouncer
>>>     nodateext
>>>     postrotate
>>>         /bin/kill -HUP `cat /var/run/pgbouncer/pgbouncer.pid
>>> 2>/dev/null` 2> /dev/null || true
>>>     endscript
>>> }
>>>
>>> "create" is ignored if "copytruncate" is used.  And having a postrotate
>>> script to send a HUP signal is also pointless if copytruncate is used.
>>> We need to decide on one way to do it: either copytruncate, or rename
>>> and SIGHUP.
>>>
>>> It also seems to me that this might be a bit simpler if we created a
>>> subdirectory /var/log/pgbouncer/ for all the log files.  Then we
>>> wouldn't have the permissions issues that the "create" directory is
>>> attempting to solve.
>>
>> Just committed a fix for this. Can you please pull 9.4 tree and see
>> whether all problems you reported have been fixed or not? I can push the
>> packages tomorrow or so.
> 
> I haven't tested it, but I think the currently committed logrotate file
> won't work at all, because *both* the copytruncate the the postrotate
> script were removed.  You need to keep at least one.
> 
> Also, I think the /var/log/pgbouncer/ directory needs to be created
> somewhere in the spec file.

This is still not fixed.



-- 
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgbouncer logrotate configuration
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox