public inbox for [email protected]  
help / color / mirror / Atom feed
From: Jeff Frost <[email protected]>
To: Martín Marqués <[email protected]>
Cc: Justin King <[email protected]>
Cc: [email protected]
Subject: Re: repmgr.service
Date: Tue, 22 Dec 2015 18:52:42 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAL3i3zT1NXVTyO=jOSXTnj3Uch9T569-LMyehDrUYqn0X+g2=w@mail.gmail.com>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-pkg-yum>

Sorry for the slow reply on this.

We did make some changes recently, but it seems this was not one of them.

A patch would definitely speed us up and would be most welcome!


> On Dec 17, 2015, at 12:25 PM, Martín Marqués <[email protected]> wrote:
> 
> Hi,
> 
> I see this hasn't been committed yet into the pgrpms git repo.
> 
> Is it under review? If so I can say the changes are good, and if needed
> I can send over a patch for easy applying.
> 
> Regards,
> 
> 
> El 13/11/15 a las 22:59, Justin King escribió:
>> Please modify the repmgr-9.x.service files for the packages.
>> 
>> The service files currently have:
>> 
>>    ExecStop=/usr/bin/kill -TERM ${PIDFILE}
>>    ExecReload=/usr/bin/kill -HUP ${PIDFILE}
>> 
>> 
>> /bin/kill does not accept files, you may be thinking of /bin/pkill -f 
>> 
>> Replace them with:
>> 
>>    ExecStop=/usr/bin/kill -TERM $MAINPID
>>    ExecReload=/usr/bin/kill -HUP $MAINPID
>> 
>> 
>> $MAINPID is a special systemd provided variable that references the
>> known PID of the process 
>> 
>> And add the following under the [Service] section:
>> 
>>    PIDFile=/var/run/repmgr/repmgrd-9.x.pid
>> 
>> 
>> This prevents systemd from guessing what the PID is and being wrong when
>> Type=forking 
>> 
>> As it stands now `systemctl stop repmgrd` and `systemctl reload repmgrd`
>> will always fail.
>> 
>> Justin
> 
> 
> -- 
> Martín Marqués                http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
> 
> 
> -- 
> Sent via pgsql-pkg-yum mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-pkg-yum

---
Jeff Frost <[email protected]>
Director, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/ 






view thread (16+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: repmgr.service
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox