public inbox for [email protected]
help / color / mirror / Atom feedFrom: Heath Lord <[email protected]>
To: Craig Ringer <[email protected]>
Cc: Devrim Gündüz <[email protected]>
Cc: PostgreSQL YUM ML <[email protected]>
Subject: Re: A basic spec file question
Date: Fri, 2 Oct 2020 07:04:16 -0400
Message-ID: <CA+BEBhukkX5ez12RWa6b9vUHTAd7dGsz2pwt+5TWcPP-3LTGpg@mail.gmail.com> (raw)
In-Reply-To: <CAGRY4nz=8bD_NEhFqXP3FE1zsfpSTNn83jSLRLgkuJHPpRZNcw@mail.gmail.com>
References: <[email protected]>
<CAGRY4nz=8bD_NEhFqXP3FE1zsfpSTNn83jSLRLgkuJHPpRZNcw@mail.gmail.com>
Devrim,
The issue is with the "<=" in this line:
%if 0%{?fedora} <= 31 || 0%{?rhel} <= 8 || 0%{?suse_version} >= 1315
With the "0%{variable}" format you will get "0" whenever a variable
is not defined, so whenever you do a comparison with a "<=" it will
resolve to TRUE when that variable is undefined. Since fedora and
rhel are never both defined at the same time the above logic will
always resolve to being TRUE.
Anytime you use this comparison logic to determine whether the
variable is "<=" you will also have to verify that the variable is
defined as well.
Thanks,
Heath
On Fri, Oct 2, 2020 at 5:38 AM Craig Ringer
<[email protected]> wrote:
>
> Add a %dump at the end of the spec file body and/or relevant parts throughout to see how it evaluated. %echo macros are useful too
>
> On Fri, 2 Oct 2020, 17:08 Devrim Gündüz, <[email protected]> wrote:
>>
>>
>>
>> Hi,
>>
>> I am probably missing a very basic thing, but... What is wrong in this
>> line? I am expecting Fedora 32 and 33 not do depend on CGAL package,
>> but then the Fedora 33 RPM depends on CGAL >= 4.7 .
>>
>> https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/common/sfcgal/master/sfcg...
>>
>> What am I missing?
>>
>> Regards,
>> --
>> Devrim Gündüz
>> Open Source Solution Architect, Red Hat Certified Engineer
>> Twitter: @DevrimGunduz , @DevrimGunduzTR
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: A basic spec file question
In-Reply-To: <CA+BEBhukkX5ez12RWa6b9vUHTAd7dGsz2pwt+5TWcPP-3LTGpg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox