public inbox for [email protected]  

help / color / mirror / Atom feed

From: Christoph Berg <[email protected]>
To: Justin Pryzby <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Devrim Gündüz <[email protected]>
Cc: [email protected]
Subject: Re: please build packages --with-lz4
Date: Tue, 23 Mar 2021 12:59:09 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

Re: Justin Pryzby
> > I have to wonder why we aren't just automatically checking if lz4 is
> > available and enabling it when it is...
> 
> I assume you mean at compile time, regarding autoconf macros ?
> 
> This probably doesn't apply to PGDG, but as I recall at least within debian,
> there's a preference to build either --with-... or --without-.., so that a
> library which happens to be installed doesn't create a package with an
> unintentional dependency, or a library which is not installed or something
> broken/incompatible doesn't result in a package without the intended
> dependency.

There is some value in making explicit statements in configure flags,
but if the package declares "Build-Depends: liblz4-dev" and then
configure picks that up automatically, there is not that much room for
unwanted surprises.

If we chose to deliberately go without lz4 support I'd in fact put a
--without-lz4 into the list of options.

The deeper question here is I guess, if lz4 is better than pglz, and
besides why isn't --with-lz4 the default, why isn't it the default for
all columns but needs some obsure GUC set?

Christoph

view thread (8+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: please build packages --with-lz4
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox