pg.ddx.io  pgsql-ports@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Martin Pitt <martin@piware.de>
Cc: pgsql-ports@postgresql.org, Kazuhiro Inaoka <inaoka.kazuhiro@renesas.com>
Subject: Re: m32r tas() implementation
Date: Sat, 14 Apr 2007 18:17:05 -0400
Message-ID: <23547.1176589025@sss.pgh.pa.us> (raw)
In-Reply-To: <20070414185459.GF5920@piware.de>
References: <20070414185459.GF5920@piware.de>

Martin Pitt <martin@piware.de> writes:
> Kazuhiro Inaoka recently sent me a tas() implementation for the m32r
> architecture [1]. It applies cleanly to 8.2.3 and seems otherwise
> harmless. Do you consider applying it upstream?

The patch seems strongly dependent on an OS as well as a chip, since
<sys/tas.h> is hardly to be expected to exist everywhere.  Therefore,
it is at least short an #ifdef or so.  More generally I wonder if it's
not going at it backwards: if <sys/tas.h> exists, could we use it
regardless of CPU type?

			regards, tom lane



view thread (7+ messages)  latest in thread

Message-ID: <23547.1176589025@sss.pgh.pa.us>
Permalink:  ../23547.1176589025@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/23547.1176589025@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-ports@postgresql.org
  Cc: tgl@sss.pgh.pa.us, martin@piware.de, inaoka.kazuhiro@renesas.com
  Subject: Re: m32r tas() implementation
  In-Reply-To: <23547.1176589025@sss.pgh.pa.us>
  References: <20070414185459.GF5920@piware.de> <23547.1176589025@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox