pg.ddx.io  pgsql-rrreviewers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Fetter <david@fetter.org>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: rui hua <365507506hua@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Revive line type
Date: Mon, 16 Sep 2013 15:57:03 -0700
Message-ID: <20130916225703.GA24324@fetter.org> (raw)
In-Reply-To: <20130916220432.GC4991@eldon.alvh.no-ip.org>
References: <CAHfbbWvgj-VfqW00uSKFW=r6KbvMhfaH71OQRmmU0c+2YFtQ8Q@mail.gmail.com>
	<1372296877.5915.5.camel@vanquo.pezone.net>
	<1379219721.10763.1.camel@vanquo.pezone.net>
	<20130916220432.GC4991@eldon.alvh.no-ip.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On Mon, Sep 16, 2013 at 07:04:32PM -0300, Alvaro Herrera wrote:
> Peter Eisentraut escribió:
> > Here is a new patch for the line type, with a new input/output format
> > {A,B,C}, as discussed in this thread.
> 
> I gave this a quick look.  The new input/output format appears to work
> well.  The input format using two points still works, which is nice.
> Regression tests pass.  I tried binary input and output using COPY and
> it seems to round-trip without problem.
> 
> With the two-point input, horizontal and vertical lines can accept NaNs
> without producing a NaN in the output if not necessary.
> 
> I tried "interpt" and "intersect" functions and they seem to work.
> Haven't gotten around to trying other functions or operators.

Should the things you tried and others be in the regression tests?  If
so, should we start with whatever had been in the regression tests
when the line type was dropped?

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (8+ messages)  latest in thread

Message-ID: <20130916225703.GA24324@fetter.org>
Permalink:  ../20130916225703.GA24324@fetter.org/
Also on:    postgresql.org/message-id/20130916225703.GA24324@fetter.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-rrreviewers@postgresql.org
  Cc: david@fetter.org, alvherre@2ndquadrant.com, peter_e@gmx.net, 365507506hua@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [PATCH] Revive line type
  In-Reply-To: <20130916225703.GA24324@fetter.org>
  References: <CAHfbbWvgj-VfqW00uSKFW=r6KbvMhfaH71OQRmmU0c+2YFtQ8Q@mail.gmail.com> <1372296877.5915.5.camel@vanquo.pezone.net> <1379219721.10763.1.camel@vanquo.pezone.net> <20130916220432.GC4991@eldon.alvh.no-ip.org> <20130916225703.GA24324@fetter.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox