From: Steven Schlansker <stevenschlansker@gmail.com>
To: Dave Cramer <pg@fastcrypt.com>
Cc: Craig Ringer <ringerc@ringerc.id.au>
Cc: Radosław Smogura <rsmogura@softperience.eu>
Cc: David Fetter <david@fetter.org>
Cc: Sylvain Mougenot <smougenot@sqli.com>
Cc: pgsql-jdbc@postgresql.org
Subject: Re: Re: [SQL] JDBC Statement.setQueryTimeout : is there plan to implement this?
Date: Thu, 15 Dec 2011 09:38:48 -0800
Message-ID: <0A239648-B5D6-4E58-B67B-8257AD2AA516@gmail.com> (raw)
In-Reply-To: <CADK3HHJmo4ayR=RKBeomggu48=tbGYV7HdX7FVP_QOoFt=du+Q@mail.gmail.com>
References: <CACKdPFjK_UsZ5wExD-RvBbvi6Zo-VYtoxQsCUpWXzTN9kywj7w@mail.gmail.com>
<4EE8AC41.2040505@ringerc.id.au>
<20111214161349.GA31176@fetter.org>
<4EE968FF.5010604@ringerc.id.au>
<4EE97B85.50909@ringerc.id.au>
<c138137e3524335c64e646b0e88e7dbc@mail.softperience.eu>
<4EE9FE03.7070107@ringerc.id.au>
<CADK3HHJmo4ayR=RKBeomggu48=tbGYV7HdX7FVP_QOoFt=du+Q@mail.gmail.com>
java.util.concurrent introduces ScheduledExecutorService, which fixes a lot of the problems with java.util.Timer and introduces more features.
Specifically, it enqueues timed actions and executes them on a thread pool, providing good controls both for controlling individual tasks (canceling) and the entire pool (shutting down cleanly / immediately)
It might be a good fit for implementing timeouts.
On Dec 15, 2011, at 6:17 AM, Dave Cramer wrote:
> Craig,
>
> That is the current implementation. What do you suggest as a more
> robust implementation ?
>
> Dave Cramer
>
> dave.cramer(at)credativ(dot)ca
> http://www.credativ.ca
>
>
>
> On Thu, Dec 15, 2011 at 9:02 AM, Craig Ringer <ringerc@ringerc.id.au> wrote:
>> On 12/15/2011 07:29 PM, Radosław Smogura wrote:
>>>
>>> Long, long time ago I've sent implementation with timers, you need to
>>> search archive If you need this.
>>
>>
>> If it was ages ago, you probably used java.util.Timer, right?
>>
>> java.util.Timer is not suitable for use in a JDBC driver because it doesn't
>> do any exception handling on the timer thread, it's subject to congestion on
>> the timer thread, and it offers no way for the driver to control the timer
>> thread to cleanly shut it down during unload. It's unusable in app servers
>> and not really a great idea anywhere that needs to be robust and
>> long-running.
>>
>> --
>> Craig Ringer
>>
>>
>> --
>> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgsql-jdbc
>
> --
> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-jdbc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-sql@postgresql.org
Cc: stevenschlansker@gmail.com, pg@fastcrypt.com, ringerc@ringerc.id.au, rsmogura@softperience.eu, david@fetter.org, smougenot@sqli.com, pgsql-jdbc@postgresql.org
Subject: Re: Re: [SQL] JDBC Statement.setQueryTimeout : is there plan to implement this?
In-Reply-To: <0A239648-B5D6-4E58-B67B-8257AD2AA516@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox