From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ryan Bradetich <ryan_bradetich@hp.com>
Cc: pgsql-sql@postgresql.org
Subject: Re: Problem with pg_dumpall
Date: Wed, 28 Jun 2000 02:15:40 -0400
Message-ID: <14456.962172940@sss.pgh.pa.us> (raw)
In-Reply-To: <3959355B.762D586C@hp.com>
References: <3958D5EA.82E74C68@hp.com>
<14979.962142613@sss.pgh.pa.us>
<395922BA.2F477593@hp.com>
<16833.962143321@sss.pgh.pa.us>
<3959355B.762D586C@hp.com>
Ryan Bradetich <ryan_bradetich@hp.com> writes:
> That was the problem. Good job at spotting that Tom. I just successfully
> completed a backup without using the -o
> option to pg_dumpall.
OK, if you need it with -o try the following patch against 7.0.2.
regards, tom lane
inline patch 1: src/backend/commands/copy.c (+3/-1 lines) download inline-1.patch*** src/backend/commands/copy.c.orig Wed Jun 28 02:07:58 2000
--- src/backend/commands/copy.c Wed Jun 28 02:13:01 2000
***************
*** 484,491 ****
if (oids && !binary)
{
! CopySendString(oidout(tuple->t_data->t_oid), fp);
CopySendChar(delim[0], fp);
}
for (i = 0; i < attr_count; i++)
--- 484,493 ----
if (oids && !binary)
{
! string = oidout(tuple->t_data->t_oid);
! CopySendString(string, fp);
CopySendChar(delim[0], fp);
+ pfree(string);
}
for (i = 0; i < attr_count; i++)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-sql@postgresql.org
Cc: tgl@sss.pgh.pa.us, ryan_bradetich@hp.com
Subject: Re: Problem with pg_dumpall
In-Reply-To: <14456.962172940@sss.pgh.pa.us>
References: <3958D5EA.82E74C68@hp.com> <14979.962142613@sss.pgh.pa.us> <395922BA.2F477593@hp.com> <16833.962143321@sss.pgh.pa.us> <3959355B.762D586C@hp.com> <14456.962172940@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox