From: Tom Lane <tgl@sss.pgh.pa.us>
To: Philip Warner <pjw@rhyme.com.au>
Cc: pgsql-hackers@postgresql.org
Cc: pgsql-general@hub.org
Cc: pgsql-sql@postgresql.org
Subject: Re: [HACKERS] RFC - change of behaviour of pg_get_userbyid & pg_get_viewdef?
Date: Sun, 24 Sep 2000 19:02:25 -0400
Message-ID: <15367.969836545@sss.pgh.pa.us> (raw)
In-Reply-To: <3.0.5.32.20000924131555.02807820@mail.rhyme.com.au>
References: <3.0.5.32.20000924131555.02807820@mail.rhyme.com.au>
Philip Warner <pjw@rhyme.com.au> writes:
> pg_get_viewdef
> returns 'Not a view' when passed a non-existant or non-view table
> it also signals errors when the underlying metadata can not be found.
> The proposal is to return NULL in the above cases - in the final case,
> probably also generate a NOTICE.
I don't believe it's practical to trap errors and return a NULL for
broken views. Moreover, I do not think it's a good idea to respond
to client errors (invalid view name) the same as database problems
(broken views). So, I agree with the part of the proposal that says
to return NULL instead of 'Not a view' when there is no view by the
given name, but I do not agree with trying to suppress errors due to
metadata problems.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-sql@postgresql.org
Cc: tgl@sss.pgh.pa.us, pjw@rhyme.com.au, pgsql-hackers@postgresql.org, pgsql-general@hub.org
Subject: Re: [HACKERS] RFC - change of behaviour of pg_get_userbyid & pg_get_viewdef?
In-Reply-To: <15367.969836545@sss.pgh.pa.us>
References: <3.0.5.32.20000924131555.02807820@mail.rhyme.com.au> <15367.969836545@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox