agora inbox for pgsql-sql@postgresql.org  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Voillequin, Jean-Marc <Jean-Marc.Voillequin@moodys.com>
Cc: pgsql-bugs@lists.postgresql.org
Cc: pgsql-sql@lists.postgresql.org
Subject: Re: Weird "could not determine which collation to use for string comparison" with LEAST/GREATEST on PG11 procedure
Date: Tue, 05 Feb 2019 09:46:27 -0500
Message-ID: <19783.1549377987@sss.pgh.pa.us> (raw)
In-Reply-To: <66209b1a-db5b-d578-6674-1be789c581f5@2ndquadrant.com>
References: <1EC8157EB499BF459A516ADCF135ADCE39FFAC54@LON-WGMSX712.ad.moodys.net>
	<12249.1542824360@sss.pgh.pa.us>
	<66209b1a-db5b-d578-6674-1be789c581f5@2ndquadrant.com>

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 21/11/2018 19:19, Tom Lane wrote:
>> Yeah, same here.  I think somebody forgot to run assign_expr_collations()
>> on CALL arguments.

> This appears to fix it.

I think this should be fine as a band-aid patch.  As I mentioned
previously, I'm not really happy with our generally-unprincipled
approach to where collation assignment is called from ... but a
bug-fix patch should probably not be tasked with making that
better.  Especially not with less than a week till 11.2.

			regards, tom lane




view thread (5+ messages)  latest in thread

Message-ID: <19783.1549377987@sss.pgh.pa.us>
Permalink:  ../19783.1549377987@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19783.1549377987@sss.pgh.pa.us

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-sql@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, Jean-Marc.Voillequin@moodys.com, pgsql-bugs@lists.postgresql.org, pgsql-sql@lists.postgresql.org
  Subject: Re: Weird "could not determine which collation to use for string comparison" with LEAST/GREATEST on PG11 procedure
  In-Reply-To: <19783.1549377987@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox