pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: The Hermit Hacker <scrappy@hub.org>
Cc: pgsql-sql@postgresql.org
Subject: Re: [SQL] More efficient DELETE ... ?
Date: Sat, 22 Jan 2000 14:37:39 -0500 (EST)
Message-ID: <200001221937.OAA25487@candle.pha.pa.us> (raw)
In-Reply-To: <20925.948564467@sss.pgh.pa.us>

> The Hermit Hacker <scrappy@hub.org> writes:
> > This looks painful ...
> 
> > DELETE FROM webhit_referer_raw
> >       WHERE oid IN ( SELECT w.oid
> >                        FROM webhit_referer_raw w, referrer_data r
> >                       WHERE stat_date < 'Jan 17 2000 15:05:00'
> >                         AND w.referrer_url = r.referrer );
> 
> I believe you can do
> 
> DELETE FROM webhit_referer_raw
> WHERE referrer_url = referrer_data.referrer
>       AND referrer_data.stat_date < 'Jan 17 2000 15:05:00';
> 
> (I assume stat_date is in referrer_data, otherwise this'd be easy.)
> 
> This is an example where Postgres' willingness to create implicit FROM
> clause entries is a win ... AFAIK you couldn't do it in standard SQL,
> since for some reason DELETE doesn't take a FROM clause.

Good point.  I had forgotten all about that.

Should I cover that in my book?

What about the NOTICE we were going to add when this happens.  You will
see a WARN_FROM define in parser/*.c.  I had to disable the message
because the regression tests were failing.  They have to be regenerated
after I do this, but I can't do that here.  Do people still want the
message?  Can someone regenerate the regression output after I am done?

In fact, someone can just remove the #ifdef WARN_FROM defines around the
code and regenerate the regression tests and all will stay in sync.


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026



view thread (7+ messages)  latest in thread

Message-ID: <200001221937.OAA25487@candle.pha.pa.us>
Permalink:  ../200001221937.OAA25487@candle.pha.pa.us/
Also on:    postgresql.org/message-id/200001221937.OAA25487@candle.pha.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: pgman@candle.pha.pa.us, tgl@sss.pgh.pa.us, scrappy@hub.org
  Subject: Re: [SQL] More efficient DELETE ... ?
  In-Reply-To: <200001221937.OAA25487@candle.pha.pa.us>
  References: <20925.948564467@sss.pgh.pa.us> <200001221937.OAA25487@candle.pha.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox