pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jan Wieck <janwieck@Yahoo.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jan Wieck <janwieck@Yahoo.com>
Cc: Joel Burton <jburton@scw.org>
Cc: pgsql-hackers@postgresql.org
Cc: pgsql-sql@postgresql.orgg
Subject: Re: [SQL] Rules with Conditions: Bug, or Misunderstanding
Date: Mon, 4 Dec 2000 14:04:51 -0500 (EST)
Message-ID: <200012041904.OAA17594@jupiter.jw.home> (raw)
In-Reply-To: <27501.975888276@sss.pgh.pa.us>

Tom Lane wrote:
> Jan Wieck <janwieck@Yahoo.com> writes:
> > Tom Lane wrote:
> >> Hm.  Perhaps the "cannot update view" test is too strict --- it's not
> >> bright enough to realize that the two rules together cover all cases,
> >> so it complains that you *might* be trying to update the view.  As the
> >> code stands, you must provide an unconditional DO INSTEAD rule to
> >> implement insertion or update of a view.
>
> >     Disagree.
>
> >     A  conditional rule splits the command into two, one with the
> >     rules action and  the  condition  added,  one  which  is  the
> >     original  statement  plus the negated condition. So there are
> >     cases left where an INSERT can happen to  the  view  relation
> >     and it's the job of this test to prevent it.
>
> Well, in that case the present code is broken, because it's going to
> spit up if any part of the rewritten query shows the view as result
> relation (cf. QueryRewrite() ... note that this logic no longer looks
> much like it did the last time you touched it ;-)).  You'd have to
> convert the existing rewrite-time test into a runtime test in order to
> see whether the query actually tries to insert any tuples into the view.

    Yepp.

> While that is maybe reasonable for insertions, it's totally silly
> for update and delete queries.  Since the view itself can never contain
> any tuples to be updated or deleted, a runtime test that errors out
> when one attempts to update or delete such a tuple could never fire.
> I don't think that means that we shouldn't complain about an update
> or delete on a view.
>
> I think the test is best left as-is...

    Since  conditional  rules  aren't  any  better compared to an
    unconditional multi-action  instead  rule  where  the  single
    actions  have all the different conditions, let's leave it as
    is and insist on one unconditional instead rule.


Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #





view thread (11+ messages)

Message-ID: <200012041904.OAA17594@jupiter.jw.home>
Permalink:  ../200012041904.OAA17594@jupiter.jw.home/
Also on:    postgresql.org/message-id/200012041904.OAA17594@jupiter.jw.home

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: janwieck@Yahoo.com, tgl@sss.pgh.pa.us, jburton@scw.org, pgsql-hackers@postgresql.org, pgsql-sql@postgresql.orgg
  Subject: Re: [SQL] Rules with Conditions: Bug, or Misunderstanding
  In-Reply-To: <200012041904.OAA17594@jupiter.jw.home>
  References: <27501.975888276@sss.pgh.pa.us> <200012041904.OAA17594@jupiter.jw.home>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox