pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jan Wieck <janwieck@Yahoo.com>
To: josh@agliodbs.com
Cc: sqllist <pgsql-sql@postgreSQL.org>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: [SQL] PL/PGSQL function with parameters
Date: Thu, 8 Feb 2001 06:37:22 -0500 (EST)
Message-ID: <200102081137.GAA03502@jupiter.greatbridge.com> (raw)
In-Reply-To: <3A803856.DB172929@agliodbs.com>

Josh Berkus wrote:
> Tom, Jan, Michael,
>
> > While I have not looked closely, I seem to recall that plpgsql handles
> > INTO by stripping that clause out of the statement before it's passed to
> > the SQL engine.  Evidently that's not happening in the EXECUTE case.
> >
> > Jan, do you agree this is a bug?  Is it reasonable to try to repair it
> > for 7.1?  If we do not change the behavior of EXECUTE now, I fear it
> > will be too late --- some people will come to depend on the existing
> > behavior.
>
> If you think that's the best way.  What we're really all wanting is a wy
> in PL/pgSQL to pass a parameter as an object name.  Doing it *without*
> using EXECUTE would be even better than modifying EXECUTE to accomdate
> SELECT ... INTO variable.
>
> If we can write queries that address tables by OID, that would give us a
> quick workaround ... get the OID from pg_class, then pass it to the
> query as variables of type OID:
>
> SELECT column1_oid, column2_oid FROM table_oid
> WHERE column2_oid = variable1
> ORDER BY column1_oid;
>
> OF course, having PL/pgSQL do this automatically would be even better,
> but I suspect would require a *lot* of extra programming by Jan.

    Couple of problems here:

    1.  The  main parser, which is used in turn by the SPI stuff,
        doesn't  allow   parameters   passed   in   for   object-
        identifiers.

    2.  I'm  not sure if *all* statements are really supported by
        SPI_prepare() plus SPI_execp().  EXECUTE  currently  uses
        SPI_exec() to directly invoke the querystring.

    3.  PL/pgSQL  needs  a  clean way to identify statements that
        shall not be cached. First things that come to mind are
        -   statements using temporary objects
        -   statements invoking utility  commands  (or  generally
            any DDL)
        -   statements having parameters for object-identifiers

        If  identified  as  such  non-cacheable  query,  PL/pgSQL
        doesn't use SPI_saveplan() but recreates a new plan every
        time.

    4.  PL   handlers   in  general  should  have  a  registering
        mechanism for a callback function. On any  schema  change
        (i.e.  shared  syscache  invalidation)  this  function is
        called,  causing  the  PL  handler  to  invalidate  *ALL*
        function  bytecodes  and  cached  plans. Keeping track of
        things like "var table.att%TYPE" used in a function would
        be a mess - so better throw away anything.

    Yes, that's a *lot* to do.


Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #



_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com




view thread (15+ messages)  latest in thread

Message-ID: <200102081137.GAA03502@jupiter.greatbridge.com>
Permalink:  ../200102081137.GAA03502@jupiter.greatbridge.com/
Also on:    postgresql.org/message-id/200102081137.GAA03502@jupiter.greatbridge.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: janwieck@Yahoo.com, josh@agliodbs.com, pgsql-hackers@postgreSQL.org
  Subject: Re: [SQL] PL/PGSQL function with parameters
  In-Reply-To: <200102081137.GAA03502@jupiter.greatbridge.com>
  References: <3A803856.DB172929@agliodbs.com> <200102081137.GAA03502@jupiter.greatbridge.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox