From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jie Liang <jie@stbernard.com>
Cc: PostgreSQL-patches <pgsql-patches@postgresql.org>
Subject: Re: [SQL] pg_restore cannot restore function
Date: Thu, 4 Jul 2002 01:36:09 -0400 (EDT)
Message-ID: <200207040536.g645a9301288@candle.pha.pa.us> (raw)
In-Reply-To: <502.1025760837@sss.pgh.pa.us>
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > The following patch fixes all of these, and it will be in 7.3.
>
> It will? Kindly explain what the heck this is doing. It looks to
> me like it will probably break more cases than it fixes. AFAICS
> it's just completely muddying the waters about what is quoted and
> what isn't ...
Well, the waters were already muddy. Doing a pg_dump -Ft, you will see
with the old code how the tags for functions had quotes, and how the
GRANT/REVOKE has quotes for table names, while the CREATE TABLE tags for
these do not. This fixes that, and tries to get the -P string they
enter for pg_restore to match the tag by removing spaces.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-sql@postgresql.org
Cc: pgman@candle.pha.pa.us, tgl@sss.pgh.pa.us, jie@stbernard.com, pgsql-patches@postgresql.org
Subject: Re: [SQL] pg_restore cannot restore function
In-Reply-To: <200207040536.g645a9301288@candle.pha.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox