pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Rajesh Kumar Mallah <mallah@trade-india.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-sql@postgresql.org
Subject: Re: /* */ comments showing up in pg_stat_activity
Date: Sat, 26 Apr 2003 10:05:05 -0400 (EDT)
Message-ID: <200304261405.h3QE55W19202@candle.pha.pa.us> (raw)
In-Reply-To: <200304261018.43661.mallah@trade-india.com>

Rajesh Kumar Mallah wrote:
> On Saturday 26 Apr 2003 8:35 am, Tom Lane wrote:
> > Jan Wieck <JanWieck@Yahoo.com> writes:
> > > The question back is from where does such a query with a comment come?
> > > If it is a standard client like psql, it could happen someday that this
> > > client does some filtering.
> 
> 
> Yes its thru psql only , i run a SQL batch using
> psql -e -h db -f batch.sql
> 
> In case future version of psql strips them it would
> still be nice if libpq continue supporting it 
> i feel it would be a nice feature for keeping track of
> queries.

[ After not replying to the proper question before, I will try again. :-) ]

The actual stripping of comments in psql is a little more complex.  For
example, this will not strip:

	SELECT /* test */ 1;

while this will strip comments:

	SELECT 1; /* test */

and leading comments are not stripped either:

	/* test */ SELECT 1;

so if the comment is _inside_ a query, it will be OK, but outside and
trailing, psql processes the comment itself so it can display the proper
prompting:

	test=> /*
	test*> test

            ^
	test*> */

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073




view thread (8+ messages)  latest in thread

Message-ID: <200304261405.h3QE55W19202@candle.pha.pa.us>
Permalink:  ../200304261405.h3QE55W19202@candle.pha.pa.us/
Also on:    postgresql.org/message-id/200304261405.h3QE55W19202@candle.pha.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-sql@postgresql.org
  Cc: pgman@candle.pha.pa.us, mallah@trade-india.com, tgl@sss.pgh.pa.us
  Subject: Re: /* */ comments showing up in pg_stat_activity
  In-Reply-To: <200304261405.h3QE55W19202@candle.pha.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox