From: Bruce Momjian <bruce@momjian.us>
To: Jim Nasby <jimn@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: gdavis@refractions.net
Cc: pgsql-sql@postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] timestamp subtraction (was Re: formatting intervals with to_char)
Date: Tue, 20 Feb 2007 20:07:11 -0500 (EST)
Message-ID: <200702210107.l1L17Bm21179@momjian.us> (raw)
In-Reply-To: <DB91DDA2-F0F2-42CF-B5E8-A481E622F1CD@enterprisedb.com>
One problem with removing justify_hours() is that this is going to
return '24:00:00', rather than '1 day:
test=> select '2004-01-02 00:00:00'::timestamptz - '2004-01-01
00:00:00'::timestamptz;
?column?
----------
24:00:00
(1 row)
---------------------------------------------------------------------------
Jim Nasby wrote:
> On Oct 5, 2006, at 11:50 AM, Tom Lane wrote:
> > regression=# select ('2006-09-15 23:59:00'::timestamp - '2006-09-01
> > 09:30:41'::timestamp);
> > ?column?
> > ------------------
> > 14 days 14:28:19
> > (1 row)
> >
> > should be reporting '350:28:19' instead.
> >
> > This is a hack that was done to minimize the changes in the regression
> > test expected outputs when we changed type interval from months/
> > seconds
> > to months/days/seconds. But I wonder whether it wasn't a dumb idea.
> > It is certainly inconsistent, as noted in the code comments.
> >
> > I'm tempted to propose that we remove the justify_hours call, and tell
> > anyone who really wants the old results to apply justify_hours() to
> > the
> > subtraction result for themselves. Not sure what the fallout would
> > be,
> > though.
>
> I suspect there's applications out there that are relying on that
> being nicely formated for display purposes.
>
> I agree it should be removed, but we might need a form of backwards
> compatibility for a version or two...
> --
> Jim Nasby jimn@enterprisedb.com
> EnterpriseDB http://enterprisedb.com 512.569.9461 (cell)
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-sql@postgresql.org
Cc: bruce@momjian.us, jimn@enterprisedb.com, tgl@sss.pgh.pa.us, gdavis@refractions.net, pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] timestamp subtraction (was Re: formatting intervals with to_char)
In-Reply-To: <200702210107.l1L17Bm21179@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox