pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christopher Kings-Lynne <chriskl@familyhealth.com.au>
Cc: Ligia Pimentel <lmpimentel@yahoo.com>
Cc: Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [SQL] An easy question about creating a primary key
Date: Mon, 03 Dec 2001 21:40:20 -0500
Message-ID: <21442.1007433620@sss.pgh.pa.us> (raw)
In-Reply-To: <21379.1007432989@sss.pgh.pa.us>
References: <GNELIHDDFBOCMGBFGEFOCEKHCAAA.chriskl@familyhealth.com.au>
	<21379.1007432989@sss.pgh.pa.us>

Now that I look at it, I think I made the relevant changes in the
parser:

2001-10-11 20:07  tgl

	* doc/src/sgml/ref/alter_table.sgml, src/backend/catalog/pg_type.c,
	src/backend/commands/command.c, src/backend/parser/analyze.c,
	src/backend/tcop/utility.c, src/include/commands/command.h,
	src/include/nodes/parsenodes.h,
	src/test/regress/expected/alter_table.out,
	src/test/regress/expected/foreign_key.out: Break
	transformCreateStmt() into multiple routines and make
	transformAlterStmt() use these routines, instead of having lots of
	duplicate (not to mention should-have-been-duplicate) code.  Adding
	a column with a CHECK constraint actually works now, and the tests
	to reject unsupported DEFAULT and NOT NULL clauses actually fire
	now.  ALTER TABLE ADD PRIMARY KEY works, modulo having to have
	created the column(s) NOT NULL already.

I was mainly interested in eliminating the inconsistencies in parse-time
handling of CREATE TABLE and ALTER TABLE, and the ensuing bugs mentioned
in the commit log.  I didn't think much about the possibility that I was
obsoleting stuff in command.c, but maybe I did.

			regards, tom lane



view thread (13+ messages)  latest in thread

Message-ID: <21442.1007433620@sss.pgh.pa.us>
Permalink:  ../21442.1007433620@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/21442.1007433620@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-sql@postgresql.org
  Cc: tgl@sss.pgh.pa.us, chriskl@familyhealth.com.au, lmpimentel@yahoo.com, pgsql-hackers@postgresql.org
  Subject: Re: [SQL] An easy question about creating a primary key
  In-Reply-To: <21442.1007433620@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox