pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-bugs@postgresql.org
Subject: Re: Bug #652: NAMEDATALEN limitations
Date: Tue, 30 Apr 2002 16:04:33 -0400
Message-ID: <21990.1020197073@sss.pgh.pa.us> (raw)
In-Reply-To: <21413.1020192353@sss.pgh.pa.us>
References: <20020430181519.5E5D9475985@postgresql.org>
	<21326.1020191577@sss.pgh.pa.us>
	<21413.1020192353@sss.pgh.pa.us>

I said:
> One possible theory is that if NAMEDATALEN isn't a multiple of
> sizeof(int), the compiler's idea of sizeof(NameData) will probably be
> NAMEDATALEN rounded up to the next multiple of sizeof(int).

For the record, this does indeed seem to be the root cause for Erik's
complaint.  relcache.c declares the key size for its relation name
cache index as sizeof(NameData) --- so if that's larger than NAMEDATALEN
the hashtable code will end up trying to compare pad bytes that
probably haven't been zeroed out.

It looks to me like it would not really be practical to expect the
system to work when sizeof(NameData) is different from NAMEDATALEN;
we could maybe eliminate the existing discrepancies but more would
surely creep in.  So I've added comments to document that NAMEDATALEN
must be a multiple of sizeof(int).

BTW, I suspect that Names used as hashtable keys may explain the
residual speed differences that people have been reporting for large
values of NAMEDATALEN.  The dynahash.c code assumes fixed-length keys
and will compare all bytes out to the specified length, no matter what
--- so the extra cycles may all be spent in key comparisons for
dynahash tables.  Perhaps this could be fixed.

			regards, tom lane



view thread (4+ messages)

Message-ID: <21990.1020197073@sss.pgh.pa.us>
Permalink:  ../21990.1020197073@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/21990.1020197073@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-sql@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-bugs@postgresql.org
  Subject: Re: Bug #652: NAMEDATALEN limitations
  In-Reply-To: <21990.1020197073@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox