From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ron Peterson <rpeterso@mtholyoke.edu>
Cc: pgsql-sql@postgresql.org
Subject: Re: insert rule doesn't see id field
Date: Thu, 09 Jan 2003 23:53:42 -0500
Message-ID: <27958.1042174422@sss.pgh.pa.us> (raw)
In-Reply-To: <20030110020707.GA9048@mtholyoke.edu>
References: <20030107145422.GE12245@mtholyoke.edu>
<13558.1041955268@sss.pgh.pa.us>
<20030108181303.GA23456@mtholyoke.edu>
<20030109191258.GA6739@mtholyoke.edu>
<2930.192.168.1.16.1042142044.squirrel@mainbox.archonet.com>
<20030109215056.GA7798@mtholyoke.edu>
<20030110020707.GA9048@mtholyoke.edu>
Ron Peterson <rpeterso@mtholyoke.edu> writes:
> On Thu, Jan 09, 2003 at 04:50:56PM -0500, Ron Peterson wrote:
>> colindices = (int *) malloc (ncols * sizeof (int));
> Of course we should verify that malloc succeeded...
Actually, the correct answer is "you should not be using malloc() in
backend functions". You should be using palloc, or possibly
MemoryContextAlloc, either of which will elog if it can't get space.
> if (colindices == NULL) {
> elog (ERROR, "noupcol: malloc failed\n");
> SPI_finish();
> return PointerGetDatum (NULL);
> }
This is even more pointless. Control does not return from elog(ERROR),
so the two following lines are dead code.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-sql@postgresql.org
Cc: tgl@sss.pgh.pa.us, rpeterso@mtholyoke.edu
Subject: Re: insert rule doesn't see id field
In-Reply-To: <27958.1042174422@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox