pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ang Chin Han <angch@pintoo.com>
Cc: pgsql-sql@postgresql.org
Subject: Re: Functions too slow, even with iscachable?
Date: Mon, 07 Aug 2000 10:58:27 -0400
Message-ID: <6058.965660307@sss.pgh.pa.us> (raw)
In-Reply-To: <20000807171110.A31838@pintoo.com>
References: <20000807171110.A31838@pintoo.com>

Ang Chin Han <angch@pintoo.com> writes:
> I have a query which runs fast:
> SELECT passwd FROM ticket WHERE name = ticket2name('test-006kdt') AND
>     survey_id = ticket2survey_id('test-006kdt');

> But slows down to a crawl when I wrapped it in a function:

> CREATE FUNCTION ticket2passwd(text) RETURNS text AS
>     'SELECT passwd FROM ticket WHERE name = ticket2name($1) AND
>     ticket2survey_id($1)' LANGUAGE 'sql' WITH (iscachable);

(I assume the lack of "survey_id =" here is just a cut-and-paste error?)

I think what you're getting bit by is that the optimizer doesn't
recognize "var = function(param)" as being a potential indexscan clause.
Does EXPLAIN show that the first query is producing an indexscan plan?

I have not tried it, but I think you could get around this problem in
plpgsql, along the lines of
	tmp1 = ticket2name($1);
	tmp2 = ticket2survey_id($1);
	SELECT passwd FROM ticket WHERE name = tmp1 AND survey_id = tmp2;
since the tmp vars will look like params to the optimizer and "var = param"
is indexable.

Looks like we need to teach the optimizer that expressions involving
params can be treated like simple params for the purposes of
optimization.

			regards, tom lane



view thread (8+ messages)  latest in thread

Message-ID: <6058.965660307@sss.pgh.pa.us>
Permalink:  ../6058.965660307@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/6058.965660307@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: tgl@sss.pgh.pa.us, angch@pintoo.com
  Subject: Re: Functions too slow, even with iscachable?
  In-Reply-To: <6058.965660307@sss.pgh.pa.us>
  References: <20000807171110.A31838@pintoo.com> <6058.965660307@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox