pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Brothers <johnbr@mindspring.com>
Cc: pgsql-general@hub.org
Cc: pgsql-sql@hub.org
Subject: Re: [SQL] RE: [GENERAL] Problem with SELECT on large negative INT4
Date: Thu, 27 Jan 2000 23:49:14 -0500
Message-ID: <9485.949034954@sss.pgh.pa.us> (raw)
In-Reply-To: <4.1.20000127224856.00c97350@pop.mindspring.com>
References: <NDBBIJLOILGIKBGDINDFAEGLCCAA.Inoue@tpf.co.jp>
	<4.1.20000127224856.00c97350@pop.mindspring.com>

John Brothers <johnbr@mindspring.com> writes:
> I don't think that patch will work - Hiroshi whipped up that patch for
> me a week ago for a different problem - we have a table with duplicate
> primary keys, which seems to be an arithmetic overflow problem because
> the index key values can be both very large positive and very large
> negative numbers.

Actually, if Nicolas' table contains both very large positive and very
large negative integers, then his index could be messed up pretty badly.
What Hiroshi saw (and I missed :-() was that btint4cmp can fail and
return a result of the wrong sign if the difference between two integers
overflows.  Since index sorting depends critically on the assumption
that the comparator always returns consistent results (a < b and b < c
must imply a < c, but this can fail if a - c overflows), you could have
an out-of-order index.  And then probes into the index could fail to
find items they should find ... which is exactly the complained-of
symptom.

Hiroshi neglected to mention that you'd probably need to drop and
recreate the index after applying the patch; if it's indeed out of
order, just patching the comparator bug isn't enough to fix it.

			regards, tom lane



view thread (18+ messages)  latest in thread

Message-ID: <9485.949034954@sss.pgh.pa.us>
Permalink:  ../9485.949034954@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/9485.949034954@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: tgl@sss.pgh.pa.us, johnbr@mindspring.com, pgsql-general@hub.org, pgsql-sql@hub.org
  Subject: Re: [SQL] RE: [GENERAL] Problem with SELECT on large negative INT4
  In-Reply-To: <9485.949034954@sss.pgh.pa.us>
  References: <NDBBIJLOILGIKBGDINDFAEGLCCAA.Inoue@tpf.co.jp> <4.1.20000127224856.00c97350@pop.mindspring.com> <9485.949034954@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox