From: Radosław Smogura <rsmogura@softperience.eu>
To: Craig Ringer <ringerc@ringerc.id.au>
Cc: David Fetter <david@fetter.org>
Cc: Sylvain Mougenot <smougenot@sqli.com>
Cc: pgsql-jdbc@postgresql.org
Subject: Re: Re: [SQL] JDBC Statement.setQueryTimeout : is there plan to implement this?
Date: Thu, 15 Dec 2011 21:49:02 +0100
Message-ID: <cce4f7e7bf48ceaf9fb8a3594911acce@mail.softperience.eu> (raw)
In-Reply-To: <4EE9FE03.7070107@ringerc.id.au>
References: <CACKdPFjK_UsZ5wExD-RvBbvi6Zo-VYtoxQsCUpWXzTN9kywj7w@mail.gmail.com>
<4EE8AC41.2040505@ringerc.id.au>
<20111214161349.GA31176@fetter.org>
<4EE968FF.5010604@ringerc.id.au>
<4EE97B85.50909@ringerc.id.au>
<c138137e3524335c64e646b0e88e7dbc@mail.softperience.eu>
<4EE9FE03.7070107@ringerc.id.au>
On Thu, 15 Dec 2011 22:02:43 +0800, Craig Ringer wrote:
> On 12/15/2011 07:29 PM, Radosław Smogura wrote:
>> Long, long time ago I've sent implementation with timers, you need
>> to search archive If you need this.
>
> If it was ages ago, you probably used java.util.Timer, right?
>
> java.util.Timer is not suitable for use in a JDBC driver because it
> doesn't do any exception handling on the timer thread, it's subject
> to
> congestion on the timer thread, and it offers no way for the driver
> to
> control the timer thread to cleanly shut it down during unload. It's
> unusable in app servers and not really a great idea anywhere that
> needs to be robust and long-running.
>
> --
> Craig Ringer
Indeed it was Timer with subclassed TimerTask. In any way
implementation was that it was prepared for choosing per connection (and
per connection is used during normal execution), per data source, or per
class loader (this is used in case of data sources).
For shutting down implementation is clear thread associated with Timer
will go away if no more tasks are scheduled and there is no more
references to Timer. Demonizing timer is quite enough.
From implementation if I recall well I used a little bit different
concept to create "atomic" operations chain for query executor protected
in addition with timer - and I think this concept was fully realized.
Regards,
Radosław Smogura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-sql@postgresql.org
Cc: rsmogura@softperience.eu, ringerc@ringerc.id.au, david@fetter.org, smougenot@sqli.com, pgsql-jdbc@postgresql.org
Subject: Re: Re: [SQL] JDBC Statement.setQueryTimeout : is there plan to implement this?
In-Reply-To: <cce4f7e7bf48ceaf9fb8a3594911acce@mail.softperience.eu>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox